Skip to content

Commit 565a96e

Browse files
fix(ui): fix error overlay issue + center layout for error and loading states
1 parent 5962c55 commit 565a96e

4 files changed

Lines changed: 11 additions & 13 deletions

File tree

packages/aurora/src/client/routes/_auth/projects/$projectId/storage/-components/Ceph/Containers/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ export const CephContainers = () => {
189189
// Handle loading state
190190
if (isLoading) {
191191
return (
192-
<Stack className="fixed inset-0" distribution="center" alignment="center" direction="vertical">
192+
<Stack className="absolute inset-0" distribution="center" alignment="center" direction="vertical">
193193
<Spinner variant="primary" size="large" className="mb-2" />
194194
<Trans>Loading Buckets...</Trans>
195195
</Stack>
@@ -201,7 +201,7 @@ export const CephContainers = () => {
201201
const errorMessage = error.message
202202

203203
return (
204-
<Stack className="fixed inset-0" distribution="center" alignment="center" direction="vertical">
204+
<Stack className="absolute inset-0" distribution="center" alignment="center" direction="vertical">
205205
<Trans>Error Loading Buckets: {errorMessage}</Trans>
206206
</Stack>
207207
)

packages/aurora/src/client/routes/_auth/projects/$projectId/storage/-components/Ceph/Objects/ObjectBrowserView.tsx

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -210,21 +210,19 @@ export function ObjectBrowserView({ bucketName }: ObjectBrowserViewProps) {
210210

211211
if (isLoading && !continuationToken) {
212212
return (
213-
<Stack direction="horizontal" gap="2" alignment="center" className="mt-8">
214-
<Spinner />
215-
<span className="text-juno-grey-light-1 text-sm">
216-
<Trans>Loading objects...</Trans>
217-
</span>
213+
<Stack className="absolute inset-0" distribution="center" alignment="center" direction="vertical">
214+
<Spinner variant="primary" size="large" className="mb-2" />
215+
<Trans>Loading objects...</Trans>
218216
</Stack>
219217
)
220218
}
221219

222220
if (error) {
223221
const errorMessage = error.message
224222
return (
225-
<p className="text-juno-red mt-4 text-sm">
223+
<Stack className="absolute inset-0" distribution="center" alignment="center" direction="vertical">
226224
<Trans>Failed to load objects: {errorMessage}</Trans>
227-
</p>
225+
</Stack>
228226
)
229227
}
230228

packages/aurora/src/client/routes/_auth/projects/$projectId/storage/-components/Swift/Containers/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ export const SwiftContainers = () => {
201201
// Handle loading state
202202
if (isLoading) {
203203
return (
204-
<Stack className="fixed inset-0" distribution="center" alignment="center" direction="vertical">
204+
<Stack className="absolute inset-0" distribution="center" alignment="center" direction="vertical">
205205
<Spinner variant="primary" size="large" className="mb-2" />
206206
<Trans>Loading Containers...</Trans>
207207
</Stack>
@@ -213,7 +213,7 @@ export const SwiftContainers = () => {
213213
const errorMessage = error.message
214214

215215
return (
216-
<Stack className="fixed inset-0" distribution="center" alignment="center" direction="vertical">
216+
<Stack className="absolute inset-0" distribution="center" alignment="center" direction="vertical">
217217
<Trans>Error Loading Containers: {errorMessage}</Trans>
218218
</Stack>
219219
)

packages/aurora/src/client/routes/_auth/projects/$projectId/storage/-components/Swift/Objects/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ export const SwiftObjects = ({ provider, containerName }: { provider: string; co
294294

295295
if (isLoading) {
296296
return (
297-
<Stack className="fixed inset-0" distribution="center" alignment="center" direction="vertical">
297+
<Stack className="absolute inset-0" distribution="center" alignment="center" direction="vertical">
298298
<Spinner variant="primary" size="large" className="mb-2" />
299299
<Trans>Loading Objects...</Trans>
300300
</Stack>
@@ -304,7 +304,7 @@ export const SwiftObjects = ({ provider, containerName }: { provider: string; co
304304
if (error) {
305305
const errorMessage = error.message
306306
return (
307-
<Stack className="fixed inset-0" distribution="center" alignment="center" direction="vertical">
307+
<Stack className="absolute inset-0" distribution="center" alignment="center" direction="vertical">
308308
<Trans>Error Loading Objects: {errorMessage}</Trans>
309309
</Stack>
310310
)

0 commit comments

Comments
 (0)