refactor(storage): extract S3 MaxKeys value to constant

Extracted hardcoded MaxKeys=1000 value to S3_MAX_KEYS_PER_REQUEST constant, addressing PR feedback from @mark-karnaukh-extern-sap.

Changes:
- Created src/server/Storage/constants.ts with S3_MAX_KEYS_PER_REQUEST constant
- Updated objectRouter.ts to use the constant
- Updated containerRouter.ts to use the constant
- Updated comment in types/ceph.ts to reference the constant name

This improves maintainability - the value is now defined in one place with proper documentation.

Author: KirylSAP

apps/aurora-portal/src/server/Storage/constants.ts

@@ -0,0 +1,10 @@
+/**
+ * Maximum number of keys returned per S3 ListObjects request.
+ *
+ * This is the AWS S3 maximum. We use this value as a performance trade-off:
+ * - Fast response times for list operations
+ * - Bucket metadata (count, size) are estimates for buckets > 1000 objects
+ *
+ * See: https://docs.aws.amazon.com/AmazonS3/latest/API/API_ListObjectsV2.html
+ */
+export const S3_MAX_KEYS_PER_REQUEST = 1000

apps/aurora-portal/src/server/Storage/routers/ceph/containerRouter.ts

@@ -10,6 +10,7 @@ import {
   type Container,
   type S3Status,
 } from "../../types/ceph"
+import { S3_MAX_KEYS_PER_REQUEST } from "../../constants"
 
 export const containerRouter = {
   status: cephProcedure.input(projectScopedInputSchema).query(async ({ ctx }): Promise<S3Status> => {
@@ -59,7 +60,7 @@ export const containerRouter = {
 
             try {
               // List objects to get count, total size, and last modified
-              // IMPORTANT: Using MaxKeys=1000 means these are ESTIMATES for buckets with >1000 objects:
+              // IMPORTANT: Using S3_MAX_KEYS_PER_REQUEST means these are ESTIMATES for buckets with >1000 objects:
               //   - count: Will be capped at 1000 (use KeyCount for actual count up to 1000)
               //   - bytes: Only sums first 1000 objects
               //   - last_modified: May miss newer objects beyond the first 1000
@@ -69,7 +70,7 @@ export const containerRouter = {
               const listObjResponse = await s3.send(
                 new ListObjectsV2Command({
                   Bucket: bucketName,
-                  MaxKeys: 1000,
+                  MaxKeys: S3_MAX_KEYS_PER_REQUEST,
                 })
               )
 

apps/aurora-portal/src/server/Storage/routers/ceph/objectRouter.ts

@@ -12,6 +12,7 @@ import {
   type ListObjectsOutput,
   type S3ObjectDetails,
 } from "../../types/ceph"
+import { S3_MAX_KEYS_PER_REQUEST } from "../../constants"
 import { z } from "zod"
 
 const deleteAllObjectsInputSchema = z.object({
@@ -126,7 +127,7 @@ export const objectRouter = {
           const listResponse = await s3.send(
             new ListObjectsV2Command({
               Bucket: containerName,
-              MaxKeys: 1000, // S3 max per request
+              MaxKeys: S3_MAX_KEYS_PER_REQUEST,
               ContinuationToken: continuationToken,
             })
           )

apps/aurora-portal/src/server/Storage/types/ceph.ts

@@ -40,7 +40,7 @@ export type Ec2CredentialWithSecret = z.infer<typeof ec2CredentialWithSecretSche
  * Includes count, bytes, and last_modified for consistent UI rendering
  *
  * IMPORTANT: count, bytes, and last_modified are ESTIMATES when buckets contain >1000 objects.
- * The list endpoint uses MaxKeys=1000 for performance, so these values are based on
+ * The list endpoint uses S3_MAX_KEYS_PER_REQUEST for performance, so these values are based on
  * a sample of objects. For accurate counts, pagination would be needed (expensive).
  */
 export const containerSchema = z.object({