Skip to content

feat(aurora): move projectOverviewBanner into ContentHeader above divider#1006

Merged
TilmanHaupt merged 2 commits into
mainfrom
banner-position-services
Jul 1, 2026
Merged

feat(aurora): move projectOverviewBanner into ContentHeader above divider#1006
TilmanHaupt merged 2 commits into
mainfrom
banner-position-services

Conversation

@MartinS-git

@MartinS-git MartinS-git commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Moves projectOverviewBanner slot into ContentHeader above the <Divider>, consistent with how serviceBanner is positioned on service pages
  • Removes the standalone slot block from $projectId/index.tsx — agreed on in design review

Changes

  • ContentHeader/ContentHeader.tsx: Added projectOverviewBanner slot rendered before <Divider>, alongside existing serviceBanner
  • $projectId/index.tsx: Removed standalone projectOverviewBanner slot block; removed now-unused slots from destructuring

Test plan

  • Navigate to a project overview page — banner should appear above the divider, consistent with service pages

Summary by CodeRabbit

  • New Features

    • Added support for an additional optional banner area in the project header.
  • Bug Fixes

    • Adjusted the project services page layout and card expand/collapse icon for a more consistent experience.
    • Updated language message loading so the app now relies on a cleaner fallback for text content.

@MartinS-git MartinS-git requested a review from a team as a code owner July 1, 2026 11:54
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@MartinS-git, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 20 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c98d9abd-ef11-408f-9f56-0f70e08c18eb

📥 Commits

Reviewing files that changed from the base of the PR and between f1b9ea6 and f2f7784.

📒 Files selected for processing (2)
  • packages/aurora/src/client/components/ContentHeader/ContentHeader.tsx
  • packages/aurora/src/client/routes/_auth/projects/$projectId/index.tsx
📝 Walkthrough

Walkthrough

This PR relocates the projectOverviewBanner slot rendering from the project services route into ContentHeader, removes the corresponding block and slots destructuring from the route component, switches an expand icon, and empties the German and English locale message JSON payloads.

Changes

ProjectOverviewBanner Relocation

Layer / File(s) Summary
Move projectOverviewBanner into ContentHeader
packages/aurora/src/client/components/ContentHeader/ContentHeader.tsx, packages/aurora/src/client/routes/_auth/projects/$projectId/index.tsx
ContentHeader now conditionally renders a projectOverviewBanner slot between serviceBanner and Divider; the project services route removes its own projectOverviewBanner block, drops slots from useRouteContext, and switches the ServiceCard header icon from expandLess to expandMore.

Locale Message Reset

Layer / File(s) Summary
Empty locale payloads
packages/aurora/src/locales/de/messages.ts, packages/aurora/src/locales/en/messages.ts
Both files replace their populated translation JSON with JSON.parse("{}") as Messages, removing all bundled message strings.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: TilmanHaupt, andypf, edda

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: moving projectOverviewBanner into ContentHeader above the divider.
Description check ✅ Passed The description covers Summary, Changes, and a Test plan, but omits Related Issues, Screenshots, and the checklist section.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch banner-position-services

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@MartinS-git MartinS-git force-pushed the banner-position-services branch from b09b250 to f2f7784 Compare July 1, 2026 12:33
@TilmanHaupt TilmanHaupt merged commit 1c34191 into main Jul 1, 2026
21 checks passed
@TilmanHaupt TilmanHaupt deleted the banner-position-services branch July 1, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants