feat(portal): offload object downloads to a Web Worker#1062
Draft
mark-karnaukh-extern-sap wants to merge 2 commits into
Draft
feat(portal): offload object downloads to a Web Worker#1062mark-karnaukh-extern-sap wants to merge 2 commits into
mark-karnaukh-extern-sap wants to merge 2 commits into
Conversation
Move object download streaming, base64 decode and Blob assembly into a dedicated module worker so large objects don't jank the main thread. Ownership of in-flight transfers moves to a module store (outside React) so a download survives ObjectsTableView unmounting during folder navigation. Includes a cancelDownload mutation to stop the BFF read server-side without waiting on the httpBatchStreamLink connection to close.
The server-side cancel procedure isn't needed: cancellation already clears the UI synchronously and aborts the worker's fetch, which tears down the request so the BFF stops reading. Remove the cancelDownload mutation and downloadAborters registry, and cancel through ctx.req.signal alone — the pre-worker behavior. Keeps the worker/store download offload intact.
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes Made
Related Issues
Screenshots (if applicable)
Testing Instructions
pnpm ipnpm run testChecklist