Skip to content

fix(playwright): fix changed login path#891

Merged
andypf merged 4 commits into
mainfrom
hgw-fix-e2e-login
Jun 11, 2026
Merged

fix(playwright): fix changed login path#891
andypf merged 4 commits into
mainfrom
hgw-fix-e2e-login

Conversation

@hgw77

@hgw77 hgw77 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

fix e2e tests and adjust .env.example to use the same port for test endpoint and server

Testing Instructions

  1. pnpm i
  2. cd apps/dashboard
  3. pnpm run test:e2e

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

Summary by CodeRabbit

  • Tests

    • Updated authentication flow in E2E tests to navigate through the root route instead of explicit login route.
    • Enhanced login page verification to validate presence of input fields and the Sign In button.
    • Modified protected route redirect expectations to wait for updated URL patterns.
  • Chores

    • Updated test environment base URL configuration.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@hgw77, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 10 minutes and 34 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 361636dd-c29b-40ad-9de2-d379491bcc78

📥 Commits

Reviewing files that changed from the base of the PR and between 5377087 and 659de5a.

📒 Files selected for processing (1)
  • apps/dashboard/e2e/helpers/auth.ts
📝 Walkthrough

Walkthrough

This PR reconfigures the Aurora Dashboard E2E test suite to use a new port (4001) and reorganizes the authentication flow to route through the root path (/) rather than an explicit login route. The auth helper's verification logic is updated accordingly, and smoke tests reflect the new expectations for login page visibility and redirect patterns.

Changes

E2E Authentication and Route Updates

Layer / File(s) Summary
Test Environment Configuration
apps/dashboard/.env.example
Playwright base URL port updated to 4001 from 4500 for E2E test execution.
Authentication Helper Navigation and Verification
apps/dashboard/e2e/helpers/auth.ts
Auth helper navigates to root (/) instead of /auth/login. Login failure detection revised to check if URL remains at baseURL or root path, replacing the previous /auth/login substring check.
Smoke Test Assertions and Redirect Expectations
apps/dashboard/e2e/smoke/unauthenticated.spec.ts
First smoke test verifies login page (domain, user, password inputs and Sign In button) at root. Protected-route redirect expectation updated to match /?redirect=... URL pattern instead of /auth/login.

🎯 2 (Simple) | ⏱️ ~8 minutes

🐰 The auth paths hop to home,
Login lives where root will roam,
Port 4001 takes the stage,
Smoke tests verify the page—
New flows dance in test arrays! 🎭

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers the summary and testing instructions, but omits required sections like 'Changes Made', 'Related Issues', and only partially completes the checklist. Add a 'Changes Made' section listing the modifications, include 'Related Issues' section, and provide complete explanations for unchecked items in the checklist.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: fixing e2e tests due to a changed login path in the authentication flow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hgw-fix-e2e-login

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@hgw77 hgw77 marked this pull request as ready for review June 11, 2026 09:47
@hgw77 hgw77 requested a review from a team as a code owner June 11, 2026 09:47

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/dashboard/e2e/helpers/auth.ts`:
- Around line 73-77: Remove the redundant and overly-broad login verification
block that checks currentUrl (the code using page.url(), page.context().baseURL
and currentUrl.endsWith("/")), since waitForURL("/projects") already verifies
navigation; delete that if-statement and its Error throw so only
waitForURL("/projects") remains, or if you prefer a check keep a precise
comparison to the base URL (not endsWith("/")) and place it before
waitForURL("/projects").
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ad25e4c1-7756-44ca-b8c4-77a8c600fff2

📥 Commits

Reviewing files that changed from the base of the PR and between 641c699 and 5377087.

📒 Files selected for processing (3)
  • apps/dashboard/.env.example
  • apps/dashboard/e2e/helpers/auth.ts
  • apps/dashboard/e2e/smoke/unauthenticated.spec.ts

Comment thread apps/dashboard/e2e/helpers/auth.ts Outdated
@andypf andypf merged commit 2c69a57 into main Jun 11, 2026
21 checks passed
@andypf andypf deleted the hgw-fix-e2e-login branch June 11, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants