Skip to content

fix(playwright): again#918

Merged
andypf merged 4 commits into
mainfrom
hgw-fix-e2e-again
Jun 16, 2026
Merged

fix(playwright): again#918
andypf merged 4 commits into
mainfrom
hgw-fix-e2e-again

Conversation

@hgw77

@hgw77 hgw77 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Fix E2E tests after project card UI changes

Summary

  • add updated env-example

  • add docu for playwright tests

  • update E2E test selectors to match the new project card structure introduced in commit fc1bc08e ("show domain name on project cards").

    Problem

    After the project card redesign, E2E tests were failing with timeouts when trying to locate project headings. The tests were looking for h1.juno-content-heading elements, but the project card structure had
    changed.

    Before:

    <h1 class="juno-content-heading">demo</h1>
    
    After:
    <span>Default</span>  <!-- Domain name -->
    <h5>demo</h5>          <!-- Project name -->

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • [] I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

Summary by CodeRabbit

Release Notes

  • Documentation

    • Added comprehensive E2E testing guide covering test scope, setup instructions, execution modes, debugging techniques, and troubleshooting guidance.
  • Tests

    • Updated E2E test selectors across multiple test suites for improved stability.
  • Chores

    • Reorganized environment configuration with explicit E2E test variable comments and updated credential placeholders.

@hgw77 hgw77 requested a review from a team as a code owner June 15, 2026 14:53
@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@hgw77, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 46 minutes and 48 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f0b044c5-0943-4b7e-b32f-248ede3073a6

📥 Commits

Reviewing files that changed from the base of the PR and between b87deda and 8a997ac.

📒 Files selected for processing (1)
  • apps/dashboard/e2e/README.md
📝 Walkthrough

Walkthrough

The PR updates Playwright E2E project heading locators from h1.juno-content-heading to h5 across three spec files (project-detail, project-navigation, projects-overview). The .env.example E2E credentials are changed from hardcoded values to placeholder strings. A new 424-line e2e/README.md is added documenting setup, commands, test categories, writing patterns, debugging, and troubleshooting.

Changes

E2E Test Suite Updates

Layer / File(s) Summary
Project heading locator fix and env credential placeholders
apps/dashboard/.env.example, apps/dashboard/e2e/ui/projects-overview.spec.ts, apps/dashboard/e2e/ui/project-detail.spec.ts, apps/dashboard/e2e/ui/project-navigation.spec.ts
The project heading locator is updated from h1.juno-content-heading to h5 in all three spec files (7 call sites total). In projects-overview.spec.ts, the text-theme-accent class assertion is also removed. The .env.example reorganizes E2E vars under a labeled comment block and replaces admin/password defaults with your-*-username/your-*-password placeholders.
E2E README
apps/dashboard/e2e/README.md
Adds a 424-line README documenting the Playwright suite scope, setup, run commands, test categories (smoke vs UI), test-writing templates, debugging options (screenshots, video, inspector, headed/debug), troubleshooting for common failures, and external resource links.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • cobaltcore-dev/aurora-dashboard#742: Restructured project heading elements in the UI, which is the upstream cause requiring the locator change from h1.juno-content-heading to h5 in these E2E specs.

Suggested reviewers

  • andypf
  • vlad-schur-external-sap
  • KirylSAP

Poem

🐇 Hop hop, the headings changed their tag,
From h1 to h5 — no need to drag!
Credentials masked, no plain-text shame,
A README born to explain the game.
Tests run green, the rabbit's glad! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title "fix(playwright): again" is vague and generic, failing to describe the actual changes made to the E2E test selectors. Replace with a specific title like "fix(playwright): update project heading locators to use h5 elements" that accurately describes the main fix.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description includes most required sections but is missing the "Testing Instructions" section and uses an incomplete checklist format.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hgw-fix-e2e-again

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/dashboard/e2e/README.md`:
- Around line 171-172: The README examples in apps/dashboard/e2e/README.md
contain outdated Playwright API usage and selectors that will mislead
contributors. At lines 171-172, update the selector from h1.juno-content-heading
to h5 to match current specs. At lines 219-220, replace the page.click("a", {
hasText }) approach with the correct Locator API pattern, as Playwright's
hasText filtering only works on the Locator API (page.locator) not directly on
page.click. Ensure both code examples reflect the current valid Playwright API
and selector strategy.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0f82ac97-aefa-4954-aa86-50ae5bc83db5

📥 Commits

Reviewing files that changed from the base of the PR and between 96ff310 and b87deda.

📒 Files selected for processing (5)
  • apps/dashboard/.env.example
  • apps/dashboard/e2e/README.md
  • apps/dashboard/e2e/ui/project-detail.spec.ts
  • apps/dashboard/e2e/ui/project-navigation.spec.ts
  • apps/dashboard/e2e/ui/projects-overview.spec.ts

Comment thread apps/dashboard/e2e/README.md Outdated
@hgw77 hgw77 enabled auto-merge (squash) June 15, 2026 15:45
@hgw77 hgw77 disabled auto-merge June 15, 2026 15:47
@andypf andypf merged commit 75b91db into main Jun 16, 2026
21 checks passed
@andypf andypf deleted the hgw-fix-e2e-again branch June 16, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants