Skip to content

feat(aurora): add serviceBanner slot#984

Merged
taymoor89 merged 2 commits into
mainfrom
983-service-banner-slot
Jun 29, 2026
Merged

feat(aurora): add serviceBanner slot#984
taymoor89 merged 2 commits into
mainfrom
983-service-banner-slot

Conversation

@taymoor89

@taymoor89 taymoor89 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Add serviceBanner slot to AuroraApp that renders below the page title divider on every service page, receiving auroraContext.currentService so consumers can conditionally show content per service.

Changes Made

  • AuroraApp.tsx - added serviceBanner to Slots type with JSDoc
  • ContentHeader.tsx - renders serviceBanner slot below the divider, passing currentService
  • README.md - added serviceBanner to the slots table, updated currentService note
  • .changeset/service-banner-slot.md - minor changeset

Related Issues

Screenshots (if applicable)

Testing Instructions

  1. pnpm i
  2. pnpm run test

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

Summary by CodeRabbit

  • New Features

    • Added a new service banner slot on service pages, shown below the page title divider.
    • The banner can use the current service context to display service-specific content.
  • Documentation

    • Updated the README to include the new slot in the available slots list.
    • Clarified which service-related slots receive the current service context.
  • Chores

    • Updated release notes to reflect a minor version bump.

@taymoor89 taymoor89 requested a review from a team as a code owner June 29, 2026 13:55
@taymoor89 taymoor89 self-assigned this Jun 29, 2026
@taymoor89 taymoor89 requested a review from Copilot June 29, 2026 13:55
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@taymoor89, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 25 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 94b1569d-c0cb-44a0-9e35-e3a9908222b3

📥 Commits

Reviewing files that changed from the base of the PR and between 114171f and 7f7fc0d.

📒 Files selected for processing (4)
  • .changeset/service-banner-slot.md
  • packages/aurora/README.md
  • packages/aurora/src/client/AuroraApp.tsx
  • packages/aurora/src/client/components/ContentHeader/ContentHeader.tsx
📝 Walkthrough

Walkthrough

Adds a new optional serviceBanner slot to the Aurora Slots interface, renders it in ContentHeader after the divider using the existing currentService value, and documents the addition in the README and a minor-release changeset.

Changes

serviceBanner slot

Layer / File(s) Summary
Slot type and ContentHeader rendering
packages/aurora/src/client/AuroraApp.tsx, packages/aurora/src/client/components/ContentHeader/ContentHeader.tsx
Slots gains an optional serviceBanner?: FC<SlotProps> entry; ContentHeader computes a serviceBanner variable via Slot with currentService and inserts it after the Divider.
Docs and changeset
packages/aurora/README.md, .changeset/service-banner-slot.md
README slots table adds a serviceBanner row and updates the currentService note; changeset marks a minor release.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

Possibly related PRs

Suggested reviewers

  • andypf
  • KirylSAP

🐇 A banner appears below the line,
For every service page to shine,
currentService passed with care,
A slot that slots right in with flair—
Hop hop hooray, the dashboard's fine! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding the serviceBanner slot.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description matches the required template and includes summary, changes, issue link, testing steps, and checklist.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 983-service-banner-slot

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new serviceBanner slot to AuroraApp and wires it into the service page header so consumers can render service-specific banner content based on auroraContext.currentService.

Changes:

  • Extends Slots with a new serviceBanner extension point (documented in type JSDoc).
  • Renders serviceBanner in ContentHeader below the title divider and passes currentService.
  • Documents the new slot in the package README and adds a changeset entry.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
packages/aurora/src/client/components/ContentHeader/ContentHeader.tsx Adds rendering for the new serviceBanner slot under the header divider and passes currentService.
packages/aurora/src/client/AuroraApp.tsx Introduces the serviceBanner slot in the public Slots type with JSDoc.
packages/aurora/README.md Documents serviceBanner in the slots table and updates the currentService note.
.changeset/service-banner-slot.md Declares a minor version bump describing the new slot.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/aurora/src/client/components/ContentHeader/ContentHeader.tsx Outdated
Comment thread packages/aurora/src/client/components/ContentHeader/ContentHeader.tsx Outdated

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/aurora/src/client/components/ContentHeader/ContentHeader.tsx`:
- Around line 33-35: The `ContentHeader` component currently renders
`slots.serviceBanner` whenever it exists, which lets it mount on non-service
routes like project pages with `currentService` unset. Update the
`serviceBanner` conditional in `ContentHeader` so it only renders when
`currentService` is present, keeping the slot gated to service routes and
preserving the existing `Slot` props behavior.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 48fe637a-cbcb-438b-968d-a1adb9bba52b

📥 Commits

Reviewing files that changed from the base of the PR and between 8689aa9 and 114171f.

📒 Files selected for processing (4)
  • .changeset/service-banner-slot.md
  • packages/aurora/README.md
  • packages/aurora/src/client/AuroraApp.tsx
  • packages/aurora/src/client/components/ContentHeader/ContentHeader.tsx

Comment thread packages/aurora/src/client/components/ContentHeader/ContentHeader.tsx Outdated
TilmanHaupt
TilmanHaupt previously approved these changes Jun 29, 2026
@taymoor89 taymoor89 enabled auto-merge (squash) June 29, 2026 14:18
@taymoor89 taymoor89 force-pushed the 983-service-banner-slot branch from 9fd75a6 to 7f7fc0d Compare June 29, 2026 14:29
@taymoor89 taymoor89 merged commit bd484d5 into main Jun 29, 2026
21 checks passed
@taymoor89 taymoor89 deleted the 983-service-banner-slot branch June 29, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants