feat(aurora): add serviceBanner slot#984
Conversation
|
Warning Review limit reached
Next review available in: 25 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughAdds a new optional ChangesserviceBanner slot
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds a new serviceBanner slot to AuroraApp and wires it into the service page header so consumers can render service-specific banner content based on auroraContext.currentService.
Changes:
- Extends
Slotswith a newserviceBannerextension point (documented in type JSDoc). - Renders
serviceBannerinContentHeaderbelow the title divider and passescurrentService. - Documents the new slot in the package README and adds a changeset entry.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/aurora/src/client/components/ContentHeader/ContentHeader.tsx | Adds rendering for the new serviceBanner slot under the header divider and passes currentService. |
| packages/aurora/src/client/AuroraApp.tsx | Introduces the serviceBanner slot in the public Slots type with JSDoc. |
| packages/aurora/README.md | Documents serviceBanner in the slots table and updates the currentService note. |
| .changeset/service-banner-slot.md | Declares a minor version bump describing the new slot. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/aurora/src/client/components/ContentHeader/ContentHeader.tsx`:
- Around line 33-35: The `ContentHeader` component currently renders
`slots.serviceBanner` whenever it exists, which lets it mount on non-service
routes like project pages with `currentService` unset. Update the
`serviceBanner` conditional in `ContentHeader` so it only renders when
`currentService` is present, keeping the slot gated to service routes and
preserving the existing `Slot` props behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 48fe637a-cbcb-438b-968d-a1adb9bba52b
📒 Files selected for processing (4)
.changeset/service-banner-slot.mdpackages/aurora/README.mdpackages/aurora/src/client/AuroraApp.tsxpackages/aurora/src/client/components/ContentHeader/ContentHeader.tsx
4e41bb7 to
9fd75a6
Compare
9fd75a6 to
7f7fc0d
Compare
Summary
Add
serviceBannerslot toAuroraAppthat renders below the page title divider on every service page, receivingauroraContext.currentServiceso consumers can conditionally show content per service.Changes Made
AuroraApp.tsx- addedserviceBannertoSlotstype with JSDocContentHeader.tsx- rendersserviceBannerslot below the divider, passingcurrentServiceREADME.md- addedserviceBannerto the slots table, updatedcurrentServicenote.changeset/service-banner-slot.md- minor changesetRelated Issues
Screenshots (if applicable)
Testing Instructions
pnpm ipnpm run testChecklist
Summary by CodeRabbit
New Features
Documentation
Chores