Keep legacy image versions

Author: Nuckal777

cloudprofilesync/runnable.go

@@ -91,11 +91,20 @@ func (r *Runnable) CheckSource(ctx context.Context, cloudProfile *v1beta1.CloudP
 		imageIndex = len(cloudProfile.Spec.MachineImages) - 1
 	}
 	image := &cloudProfile.Spec.MachineImages[imageIndex]
-	image.Versions = make([]v1beta1.MachineImageVersion, len(versions))
-	for i, version := range versions {
-		image.Versions[i] = v1beta1.MachineImageVersion{
-			ExpirableVersion: v1beta1.ExpirableVersion{Version: version.Version},
-			Architectures:    version.Architectures,
+	existingVersions := make(map[string]int, len(image.Versions))
+	for idx, version := range image.Versions {
+		existingVersions[version.Version] = idx
+	}
+	for _, version := range versions {
+		if idx, exists := existingVersions[version.Version]; exists {
+			image.Versions[idx].Architectures = version.Architectures
+		} else {
+			image.Versions = append(image.Versions, v1beta1.MachineImageVersion{
+				ExpirableVersion: v1beta1.ExpirableVersion{
+					Version: version.Version,
+				},
+				Architectures: version.Architectures,
+			})
 		}
 	}
 	if r.Provider != nil {

cloudprofilesync/runnable_test.go

@@ -72,9 +72,11 @@ var _ = Describe("Runnable", func() {
 		Expect(runnable.CheckSource(ctx, &cloudProfile)).To(Succeed())
 		Expect(cloudProfile.Spec.MachineImages).To(HaveLen(1))
 		Expect(cloudProfile.Spec.MachineImages[0].Name).To(Equal("test"))
-		Expect(cloudProfile.Spec.MachineImages[0].Versions).To(HaveLen(1))
-		Expect(cloudProfile.Spec.MachineImages[0].Versions[0].Version).To(Equal("2.0.0"))
-		Expect(cloudProfile.Spec.MachineImages[0].Versions[0].Architectures).To(Equal([]string{"arm64"}))
+		Expect(cloudProfile.Spec.MachineImages[0].Versions).To(HaveLen(2))
+		Expect(cloudProfile.Spec.MachineImages[0].Versions[0].Version).To(Equal("1.0.0"))
+		Expect(cloudProfile.Spec.MachineImages[0].Versions[0].Architectures).To(Equal([]string{"amd64"}))
+		Expect(cloudProfile.Spec.MachineImages[0].Versions[1].Version).To(Equal("2.0.0"))
+		Expect(cloudProfile.Spec.MachineImages[0].Versions[1].Architectures).To(Equal([]string{"arm64"}))
 	})
 
 	It("does not change unrelated images in the CloudProfile spec", func(ctx SpecContext) {
@@ -113,6 +115,12 @@ var _ = Describe("Runnable", func() {
 			{
 				Name: "test",
 				Versions: []v1beta1.MachineImageVersion{
+					{
+						ExpirableVersion: v1beta1.ExpirableVersion{
+							Version: "1.0.0",
+						},
+						Architectures: []string{"amd64"},
+					},
 					{
 						ExpirableVersion: v1beta1.ExpirableVersion{
 							Version: "1.1.0",