refactor: vmware host capacity kpi (#775)

Author: SoWieMarkus

helm/bundles/cortex-nova/templates/kpis.yaml

@@ -29,20 +29,6 @@ spec:
 ---
 apiVersion: cortex.cloud/v1alpha1
 kind: KPI
-metadata:
-  name: vmware-host-capacity
-spec:
-  schedulingDomain: nova
-  impl: vmware_host_capacity_kpi
-  dependencies:
-    knowledges:
-      - name: host-details
-      - name: host-utilization
-  description: |
-    This KPI tracks the total, utilized, reserved and failover capacity of VMware hosts.
----
-apiVersion: cortex.cloud/v1alpha1
-kind: KPI
 metadata:
   name: host-running-vms
 spec:
@@ -215,4 +201,18 @@ spec:
       - name: nova-flavors
       - name: limes-project-commitments
   description: |
-    This KPI tracks the resource commitments of projects running VMs on VMware hosts.
+    This KPI tracks the resource commitments of projects running VMs on VMware hosts.
+---
+apiVersion: cortex.cloud/v1alpha1
+kind: KPI
+metadata:
+  name: vmware-host-capacity
+spec:
+  schedulingDomain: nova
+  impl: vmware_host_capacity_kpi
+  dependencies:
+    knowledges:
+      - name: host-details
+      - name: host-utilization
+  description: |
+    This KPI tracks the capacity and utilization of VMware hosts in terms of CPU, RAM, and disk resources.

internal/knowledge/kpis/plugins/compute/resource_capacity_kvm_test.go

@@ -4,6 +4,7 @@
 package compute
 
 import (
+	"regexp"
 	"testing"
 
 	"github.com/cobaltcore-dev/cortex/api/v1alpha1"
@@ -38,6 +39,16 @@ type kvmMetricLabels struct {
 	Maintenance      string
 }
 
+var fqNameRe = regexp.MustCompile(`fqName: "([^"]+)"`)
+
+func getMetricName(desc string) string {
+	match := fqNameRe.FindStringSubmatch(desc)
+	if len(match) > 1 {
+		return match[1]
+	}
+	return ""
+}
+
 type kvmExpectedMetric struct {
 	Name   string // metric family name (e.g. "cortex_kvm_host_capacity_total")
 	Labels kvmMetricLabels