Remove helmify / kustomize, switch to helm-chart only.

This PR removes the helmify step and removes kustomize as an option to
render the manager/rbacs/crd.
Helmify took a lot of work creating a helm-chart based on the
boilerplate generated by kubebuilder. But ultimatively, it imposes too
many constraints to the outcome of the helm-chart and makes it hard to
implement custom renditions (like using .AppVersion as a image tag).

Thus this PR is removing the kustomize files, leaving only the generated
CRDs in the config directory (which don't need any templating) and
symlinks it to the helm chart.

Author: notandy

.github/workflows/container-registry-ghcr.yaml

@@ -30,7 +30,7 @@ jobs:
           username: ${{ github.actor }}
       - name: Extract metadata (tags, labels) for Docker
         id: meta
-        uses: docker/metadata-action@v5
+        uses: docker/metadata-action@v6
         with:
           images: ghcr.io/${{ github.repository }}
           tags: |
@@ -45,7 +45,7 @@ jobs:
             # https://github.com/docker/metadata-action#typesha
             type=sha,format=long
       - name: Set up QEMU
-        uses: docker/setup-qemu-action@v3
+        uses: docker/setup-qemu-action@v4
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v4
       - name: Build and push Docker image

.pre-commit-config.yaml

@@ -31,13 +31,3 @@ repos:
         entry: sh -c "gmake check || make check"
         language: system
         pass_filenames: false
-      - id: helmify
-        name: helmify
-        entry: sh -c "gmake helmify || make helmify"
-        language: system
-        pass_filenames: false
-      - id: go-build
-        name: go build
-        entry: sh -c "gmake build-all || make build-all"
-        language: system
-        pass_filenames: false

Makefile

@@ -125,7 +125,7 @@ check: FORCE static-check build/cover.html build-all
 
 generate: install-controller-gen
 	@printf "\e[1;36m>> controller-gen\e[0m\n"
-	@controller-gen crd rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases
+	@controller-gen crd rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=charts/kvm-node-agent/crds
 	@controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
 	@controller-gen applyconfiguration paths="./..."
 

Makefile.maker.yaml

@@ -7,7 +7,7 @@ binaries:
 
 controllerGen:
   enabled: true
-  crdOutputPath: config/crd/bases
+  crdOutputPath: charts/kvm-node-agent/crds
   objectHeaderFile: hack/boilerplate.go.txt
   rbacRoleName: manager-role
 
@@ -81,8 +81,4 @@ verbatim: |
 
   .PHONY: install-crds
   install-crds: generate ## Install CRDs into the K8s cluster specified in ~/.kube/config.
-      kubectl kustomize config/crd | kubectl apply -f -
-
-  .PHONY: helmify
-  helmify:
-      kubectl kustomize config/default | helmify -crd-dir charts/kvm-node-agent
+      kubectl apply -f config/crd/*.yaml

…/crd/bases/kvm.cloud.sap_migrations.yaml …agent/crds/kvm.cloud.sap_migrations.yamlconfig/crd/bases/kvm.cloud.sap_migrations.yaml renamed to charts/kvm-node-agent/crds/kvm.cloud.sap_migrations.yaml config/crd/bases/kvm.cloud.sap_migrations.yaml renamed to charts/kvm-node-agent/crds/kvm.cloud.sap_migrations.yaml

@@ -20,7 +20,6 @@ controllerManager:
       pkiPath: /pki
     image:
       repository: ghcr.io/cobaltcore-dev/kvm-node-agent
-      tag: latest
     resources:
       limits:
         cpu: 500m