Check that failing libvirt connection is reflected

Author: PhilippMatthes

internal/controller/hypervisor_controller.go

@@ -355,13 +355,14 @@ func (r *HypervisorReconciler) Start(ctx context.Context) error {
 		log.Error(err, "unable to connect to libvirt")
 		// Set the hypervisor's LibVirtType condition to false with the
 		// error message, so that it's visible in the status.
+		base := hypervisor.DeepCopy()
 		meta.SetStatusCondition(&hypervisor.Status.Conditions, metav1.Condition{
 			Type:    LibVirtType, // TODO: This should be a kvmv1 condition.
 			Status:  metav1.ConditionFalse,
 			Message: fmt.Sprintf("unable to connect to libvirt: %v", err),
 			Reason:  "ConnectFailed",
 		})
-		patch := client.MergeFromWithOptions(hypervisor.DeepCopy(), client.MergeFromWithOptimisticLock{})
+		patch := client.MergeFromWithOptions(base, client.MergeFromWithOptimisticLock{})
 		if err := r.Status().Patch(ctx, &hypervisor, patch); err != nil {
 			log.Error(err, "unable to update hypervisor status after failed libvirt connection")
 		}

internal/controller/hypervisor_controller_test.go

@@ -20,6 +20,7 @@ package controller
 import (
 	"context"
 	"errors"
+	"strings"
 	"time"
 
 	kvmv1 "github.com/cobaltcore-dev/openstack-hypervisor-operator/api/v1"
@@ -139,6 +140,23 @@ var _ = Describe("Hypervisor Controller", func() {
 				Expect(err).To(HaveOccurred())
 				Expect(err.Error()).To(ContainSubstring("context done while trying to connect to libvirt"))
 			}
+
+			// Verify that the hypervisor status reflects the failed libvirt connection
+			var updatedHypervisor kvmv1.Hypervisor
+			Eventually(func() bool {
+				err := k8sClient.Get(context.Background(), types.NamespacedName{Name: hypervisorName}, &updatedHypervisor)
+				if err != nil {
+					return false
+				}
+				for _, condition := range updatedHypervisor.Status.Conditions {
+					if condition.Type == "LibVirtConnection" {
+						return condition.Status == metav1.ConditionFalse &&
+							condition.Reason == "ConnectFailed" &&
+							strings.Contains(condition.Message, "connection failed")
+					}
+				}
+				return false
+			}, 2*time.Second, 100*time.Millisecond).Should(BeTrue(), "hypervisor status should reflect failed libvirt connection")
 		})
 
 		It("should fail when hypervisor resource does not exist", func() {