Clear forced_down when removing HA maintenance

  When maintenance: ha is removed, the kvm-ha-service have set
  forced_down=true on the nova-compute service. The operator's
  MaintenanceUnset path previously only re-enabled the service status
  but did not clear forced_down, leaving the compute service unable to
  accept workloads despite being marked enabled.

Author: PaulPickhardt

internal/controller/hypervisor_maintenance_controller.go

@@ -124,8 +124,13 @@ func (hec *HypervisorMaintenanceController) reconcileComputeService(ctx context.
 			return nil
 		}
 
-		// We need to enable the host as per spec
-		enableService := services.UpdateOpts{Status: services.ServiceEnabled}
+		// We need to enable the host as per spec and clear forced_down
+		// in case it was set by the HA service during maintenance.
+		falseVal := false
+		enableService := openstack.UpdateServiceOpts{
+			Status:     services.ServiceEnabled,
+			ForcedDown: &falseVal,
+		}
 		log.Info("Enabling hypervisor", "id", serviceId)
 		_, err := services.Update(ctx, hec.computeClient, serviceId, enableService).Extract()
 		if err != nil {

internal/controller/hypervisor_maintenance_controller_test.go

@@ -148,7 +148,7 @@ var _ = Describe("HypervisorMaintenanceController", func() {
 					Expect(k8sClient.Get(ctx, hypervisorName, hypervisor)).To(Succeed())
 					hypervisor.Spec.Maintenance = ""
 					Expect(k8sClient.Update(ctx, hypervisor)).To(Succeed())
-					expectedBody := `{"status": "enabled"}`
+					expectedBody := `{"status": "enabled", "forced_down": false}`
 					mockServiceUpdate(expectedBody)
 				})
 
@@ -215,7 +215,7 @@ var _ = Describe("HypervisorMaintenanceController", func() {
 							Message: "dontcare",
 						})
 					Expect(k8sClient.Status().Update(ctx, hypervisor)).To(Succeed())
-					expectedBody := `{"status": "enabled"}`
+					expectedBody := `{"status": "enabled", "forced_down": false}`
 					mockServiceUpdate(expectedBody)
 
 					eviction := &kvmv1.Eviction{