Skip to content

Commit 3b5bebc

Browse files
committed
Use removeFinalizer in DecommissionController
1 parent a08a1e3 commit 3b5bebc

1 file changed

Lines changed: 1 addition & 10 deletions

File tree

internal/controller/decomission_controller.go

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -65,18 +65,9 @@ func (r *NodeDecommissionReconciler) Reconcile(ctx context.Context, req ctrl.Req
6565
}
6666

6767
found := (labels.Set)(node.Labels).Has(labelLifecycleMode)
68-
6968
if !found {
7069
// Get out of the way
71-
var err error
72-
if controllerutil.RemoveFinalizer(node, decommissionFinalizerName) {
73-
err = r.Update(ctx, node)
74-
if err != nil {
75-
err = fmt.Errorf("failed to remove finalizer due to %w", err)
76-
}
77-
}
78-
79-
return ctrl.Result{}, err
70+
return r.removeFinalizer(ctx, node)
8071
}
8172

8273
if controllerutil.AddFinalizer(node, decommissionFinalizerName) {

0 commit comments

Comments
 (0)