Skip to content

Commit 7203224

Browse files
committed
NodeCertificateController: Increase certificate duration to 47 days
This matches the limit for CA/Browser Forum. It doesn't have to, but the reasoning behind it probably applies to us to some degree as well.
1 parent f85493e commit 7203224

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

internal/controller/node_certificate_controller.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -111,9 +111,9 @@ func (r *NodeCertificateController) ensureCertificate(ctx context.Context, node
111111
Encoding: cmapi.PKCS1,
112112
Size: 4096,
113113
},
114-
// Values for testing, increase for production to something sensible
115-
Duration: &metav1.Duration{Duration: 8 * time.Hour},
116-
RenewBefore: &metav1.Duration{Duration: 2 * time.Hour},
114+
// Matching the CA/Browser Forum's maximum duration for 2029
115+
Duration: &metav1.Duration{Duration: 47 * 24 * time.Hour},
116+
RenewBefore: &metav1.Duration{Duration: 37 * 24 * time.Hour},
117117
IsCA: false,
118118
Usages: []cmapi.KeyUsage{
119119
cmapi.UsageServerAuth,

0 commit comments

Comments
 (0)