More linter corrections

Author: fwiesel

internal/controller/aggregates_controller.go

@@ -89,15 +89,15 @@ func (r *AggregatesController) Reconcile(ctx context.Context, req ctrl.Request)
 
 	if len(toRemove) > 0 {
 		log.Info("Removing", "aggregates", toRemove)
-		for item, _ := range toRemove {
+		for item := range toRemove {
 			err = removeFromAggregate(ctx, r.computeClient, aggs, computeHost, item)
 			if err != nil {
 				return ctrl.Result{}, err
 			}
 		}
 	}
 
-	_, err = setNodeAnnotations(ctx, r.Client, node, map[string]string{annotationAggregatesApplied: node.Annotations[annotationAggregates]})
+	err = setNodeAnnotations(ctx, r.Client, node, map[string]string{annotationAggregatesApplied: node.Annotations[annotationAggregates]})
 
 	return ctrl.Result{}, err
 }

internal/controller/node_certificate_controller.go

@@ -35,8 +35,6 @@ import (
 	logger "sigs.k8s.io/controller-runtime/pkg/log"
 )
 
-const ()
-
 type NodeCertificateController struct {
 	k8sclient.Client
 	Scheme     *runtime.Scheme

internal/controller/onboarding_controller.go

@@ -324,6 +324,10 @@ func (r *OnboardingController) createOrGetTestServer(ctx context.Context, zone,
 	}
 
 	imagesList, err := images.ExtractImages(imagePages)
+	if err != nil {
+		return nil, err
+	}
+
 	for _, image := range imagesList {
 		if image.Name == testImageName {
 			imageRef = image.ID

internal/controller/traits_controller.go

@@ -91,7 +91,7 @@ func (r *TraitsController) Reconcile(ctx context.Context, req ctrl.Request) (ctr
 		}
 	}
 
-	for item, _ := range toAdd {
+	for item := range toAdd {
 		targetTraitsSet[item] = true
 	}
 
@@ -107,7 +107,7 @@ func (r *TraitsController) Reconcile(ctx context.Context, req ctrl.Request) (ctr
 		return ctrl.Result{}, result.Err
 	}
 
-	_, err = setNodeAnnotations(ctx, r.Client, node, map[string]string{annotationAppliedCustomTraits: node.Annotations[annotationCustomTraits]})
+	err = setNodeAnnotations(ctx, r.Client, node, map[string]string{annotationAppliedCustomTraits: node.Annotations[annotationCustomTraits]})
 
 	return ctrl.Result{}, err
 }
@@ -142,7 +142,7 @@ func extractTraits(node *corev1.Node, key string) (values map[string]bool) {
 // returns all elements in b not in a
 func difference(a, b map[string]bool) (diff map[string]bool) {
 	diff = make(map[string]bool, 0)
-	for item, _ := range b {
+	for item := range b {
 		_, found := a[item]
 		if !found {
 			diff[item] = true