EvictionController: Trigger retry in impossible branch too

r.addCondition should aways be true when we don't have the
status condition. Still, let's return here a requeue to make sure
we do not end up in a dead-end by accident.

Author: fwiesel

internal/controller/eviction_controller.go

@@ -94,6 +94,9 @@ func (r *EvictionReconciler) Reconcile(ctx context.Context, req ctrl.Request) (c
 			log.Info("running")
 			return ctrl.Result{}, nil
 		}
+		// We just checked if the condition is there, so this should never
+		// be reached, but let's cover our bass
+		return ctrl.Result{RequeueAfter: 1 * time.Second}, nil
 	} else if statusCondition.Status == metav1.ConditionTrue {
 		// We are running, so we need to evict the next instance
 		return r.handleRunning(ctx, eviction)