Skip to content

Commit 98eab98

Browse files
committed
Onboarding: Swallow not-found errors on delete
The old code had a logic error. We do want to bubble up errors, but only the ones which are *not* a not-found error.
1 parent 4b56d4d commit 98eab98

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

internal/controller/onboarding_controller.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ func (r *OnboardingController) completeOnboarding(ctx context.Context, host stri
315315
for _, server := range serverList {
316316
log.Info("deleting server", "name", server.Name)
317317
err = servers.Delete(ctx, r.testComputeClient, server.ID).ExtractErr()
318-
if err != nil && gophercloud.ResponseCodeIs(err, http.StatusNotFound) {
318+
if err != nil && !gophercloud.ResponseCodeIs(err, http.StatusNotFound) {
319319
return ctrl.Result{}, err
320320
}
321321
}

0 commit comments

Comments
 (0)