Skip to content

Commit d073c95

Browse files
committed
Fix logic inversion on yield
The pattern is ```go for v := range s.m { if !yield(v) { return } } ``` So, we need to return if yield() returns a false value, not a true value as in the old code.
1 parent 4c495a8 commit d073c95

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

internal/controller/hypervisor_controller.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ func updateLabelsAndAnnotations(node *metav1.ObjectMeta, hypervisor *kvmv1.Hyper
185185
hypervisor.Spec.Aggregates = slices.Collect(func(yield func(string) bool) {
186186
for _, agg := range strings.Split(aggregates, ",") {
187187
trimmed := strings.TrimSpace(agg)
188-
if trimmed != "" && yield(trimmed) {
188+
if trimmed != "" && !yield(trimmed) {
189189
return
190190
}
191191
}
@@ -198,7 +198,7 @@ func updateLabelsAndAnnotations(node *metav1.ObjectMeta, hypervisor *kvmv1.Hyper
198198
hypervisor.Spec.CustomTraits = slices.Collect(func(yield func(string) bool) {
199199
for _, trait := range strings.Split(customTraits, ",") {
200200
trimmed := strings.TrimSpace(trait)
201-
if trimmed != "" && yield(trimmed) {
201+
if trimmed != "" && !yield(trimmed) {
202202
return
203203
}
204204
}

0 commit comments

Comments
 (0)