Skip to content

Commit f11736f

Browse files
committed
Partially revert "Use zapEncoder"
Use zap.WrapCore again, as it seems to work. This partially reverts commit 9bfc3e0.
1 parent f909fe7 commit f11736f

2 files changed

Lines changed: 13 additions & 17 deletions

File tree

cmd/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ func main() {
9999
opts := ctrlzap.Options{
100100
Development: true,
101101
TimeEncoder: zapcore.ISO8601TimeEncoder,
102-
Encoder: logger.NewSanitzeReconcileErrorEncoder(zapcore.EncoderConfig{}),
102+
ZapOpts: []zap.Option{zap.WrapCore(logger.WrapCore)},
103103
StacktraceLevel: zap.DPanicLevel,
104104
}
105105
opts.BindFlags(flag.CommandLine)

internal/logger/logger.go

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -18,30 +18,26 @@ limitations under the License.
1818
package logger
1919

2020
import (
21-
"go.uber.org/zap/buffer"
2221
"go.uber.org/zap/zapcore"
2322
)
2423

25-
func NewSanitzeReconcileErrorEncoder(cfg zapcore.EncoderConfig) zapcore.Encoder {
26-
return &SanitzeReconcileErrorEncoder{zapcore.NewConsoleEncoder(cfg), cfg}
24+
type wrapCore struct {
25+
zapcore.Core
2726
}
2827

29-
type SanitzeReconcileErrorEncoder struct {
30-
zapcore.Encoder
31-
cfg zapcore.EncoderConfig
28+
func WrapCore(core zapcore.Core) zapcore.Core {
29+
return wrapCore{core}
3230
}
3331

34-
func (e *SanitzeReconcileErrorEncoder) EncodeEntry(entry zapcore.Entry, fields []zapcore.Field) (*buffer.Buffer, error) {
35-
if entry.Message == "Reconcile error" {
36-
// Downgrade the log level to debug to avoid log spam
37-
entry.Level = zapcore.WarnLevel
38-
entry.Stack = ""
32+
// Check implements zapcore.Core.
33+
func (w wrapCore) Check(entry zapcore.Entry, checkedEntry *zapcore.CheckedEntry) *zapcore.CheckedEntry {
34+
if entry.Message == "Reconciler error" {
35+
entry.Level = zapcore.DebugLevel
3936
}
40-
return e.Encoder.EncodeEntry(entry, fields)
37+
return w.Core.Check(entry, checkedEntry)
4138
}
4239

43-
func (e *SanitzeReconcileErrorEncoder) Clone() zapcore.Encoder {
44-
return &SanitzeReconcileErrorEncoder{
45-
Encoder: e.Encoder.Clone(),
46-
}
40+
// With implements zapcore.Core.
41+
func (w wrapCore) With(fields []zapcore.Field) zapcore.Core {
42+
return wrapCore{w.Core.With(fields)}
4743
}

0 commit comments

Comments
 (0)