[traits/aggregate] refactor to use hypervisor.crd, add unit tests#123
Conversation
notandy
changed the title
notandy
force-pushed
the
refactor-traits
branch
from
2acf27a to
5127a4c
Compare
fwiesel
left a comment
fwiesel
left a comment
There was a problem hiding this comment.
We still need the aggregates and traits come in over labels or annotations as they come in over the shoot spec. With the patch applied, we will simply lose these on a reinstallation.
Yeah I was thinking about that. Let's discuss it offline. |
Previous commit changed the aggregate- and custom-traits handling to the hypervisor-crd. This removed the persistence over new gardener rollouts. This PR reintroduces the persistence by transporting the aggregates/traits from server labels/annotationts to the new hypervisor CRO. Also changes the existing code from using `controllerutil.CreateOrPatch` to explictly checking if the objects is already there (and only updating status in this case). Manual overrides to the CRO would have been overwritten else. controllerutil.CreateOrPatch behaves unpredicted in a way that it won't update status for newly created CRO, only for existing ones.
e60873c brings back the persistence via server labels/annotations for now, since we didn't discussed a long-term alternative for persistence yet. |
|
Perfect, thanks. |
2 participants
No description provided.