Skip to content

remove enabling instance-ha on reconcile eviction #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PaulPickhardt merged 1 commit into from
Oct 6, 2025
Merged

remove enabling instance-ha on reconcile eviction #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions internal/controller/node_eviction_label_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,6 @@ func (r *NodeEvictionLabelReconciler) reconcileEviction(ctx context.Context, evi
Reason: fmt.Sprintf("openstack-hypervisor-operator: label %v=%v", labelEvictionRequired, maintenanceValue),
}

if err = enableInstanceHAMissingOkay(node); err != nil {
return "", fmt.Errorf("failed to enable instance ha before eviction due to %w", err)
}

if err = r.Create(ctx, eviction); err != nil {
return "", fmt.Errorf("failed to create eviction due to %w", err)
}
Expand Down
4 changes: 0 additions & 4 deletions internal/controller/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,6 @@ func enableInstanceHA(node *corev1.Node) error {
return updateInstanceHA(node, `{"enabled": true}`, []int{http.StatusOK})
}

func enableInstanceHAMissingOkay(node *corev1.Node) error {
return updateInstanceHA(node, `{"enabled": true}`, []int{http.StatusOK, http.StatusNotFound})
}

func disableInstanceHA(node *corev1.Node) error {
return updateInstanceHA(node, `{"enabled": false}`, []int{http.StatusOK, http.StatusNotFound})
}
Expand Down
Loading