Switch Hypervisor from ControllerReference to OwnerReference#135
Merged
Conversation
Contributor
|
True, probably want to remove line 183 |
fwiesel
force-pushed
the
blocking_owner_reference
branch
from
552a89d to
c9e2931
Compare
Contributor
Author
|
I've removed the line. |
ControllerReference is 'for reconciling the owner object on changes to controlled (with a Watch + EnqueueRequestForOwner)'. Since we do not want to reconcile the node on changes to the hypervisor, we are fine with OwnerReference. The WithBlockOwnerDeletion ensures that the node is only deleted, when the hypervisor resource also has been deleted. For now, it is only avoiding a theoretical race conditition of the node coming back before the hypervisor has been removed, and annotations / labels not getting propagated. It also sets the stage for moving the finalizer out of the node, and doing that on the hypervisor resource instead.
notandy
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ControllerReference is 'for reconciling the owner object on changes to controlled (with a Watch + EnqueueRequestForOwner)'.
Since we do not want to reconcile the node on changes to the hypervisor, we are fine with OwnerReference.
The WithBlockOwnerDeletion ensures that the node is only deleted, when the hypervisor resource also has been deleted. For now, it is only avoiding a theoretical race conditition of the node coming back before the hypervisor has been removed, and annotations / labels not getting propagated.
It also sets the stage for moving the finalizer out of the node, and doing that on the hypervisor resource instead.