Onboarding: Undo forceDown#140
Merged
Merged
Conversation
An HA event on a node will cause the HA service to force down the node. This is apparently persisted, so when the node comes up again, it stays forced down, even though the service was deleted. Either way, we can only onboard a node if it isn't `forcedDown`, so we might as well ensure that. We need to duplicate the gophercloud code until v3 is released, as the bugfix is unfortunately a breaking api change. See: gophercloud/gophercloud#3531 In compliance with the Apache License, I kept the attribution and wrote down where the code came from and what has been changed.
PaulPickhardt
approved these changes
Oct 10, 2025
kayrus
reviewed
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An HA event on a node will cause the HA service to force down the node.
This is apparently persisted, so when the node comes up again, it stays forced down,
even though the service was deleted.
Either way, we can only onboard a node if it isn't forcedDown, so we might as well ensure that.
We need to duplicate the gophercloud code until v3 is released, as the bugfix is unfortunately a breaking api change. See: gophercloud/gophercloud#3531
In compliance with the Apache License, I kept the attribution and wrote down where the code came from and what has been changed.