From d073c9562df70d32e0aa1118849c3a4864e88138 Mon Sep 17 00:00:00 2001 From: Fabian Wiesel Date: Tue, 14 Oct 2025 11:46:43 +0200 Subject: [PATCH] Fix logic inversion on yield The pattern is ```go for v := range s.m { if !yield(v) { return } } ``` So, we need to return if yield() returns a false value, not a true value as in the old code. --- internal/controller/hypervisor_controller.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/controller/hypervisor_controller.go b/internal/controller/hypervisor_controller.go index 108f9840..6fad14c4 100644 --- a/internal/controller/hypervisor_controller.go +++ b/internal/controller/hypervisor_controller.go @@ -185,7 +185,7 @@ func updateLabelsAndAnnotations(node *metav1.ObjectMeta, hypervisor *kvmv1.Hyper hypervisor.Spec.Aggregates = slices.Collect(func(yield func(string) bool) { for _, agg := range strings.Split(aggregates, ",") { trimmed := strings.TrimSpace(agg) - if trimmed != "" && yield(trimmed) { + if trimmed != "" && !yield(trimmed) { return } } @@ -198,7 +198,7 @@ func updateLabelsAndAnnotations(node *metav1.ObjectMeta, hypervisor *kvmv1.Hyper hypervisor.Spec.CustomTraits = slices.Collect(func(yield func(string) bool) { for _, trait := range strings.Split(customTraits, ",") { trimmed := strings.TrimSpace(trait) - if trimmed != "" && yield(trimmed) { + if trimmed != "" && !yield(trimmed) { return } }