Skip to content

HypervisorMaintenance: Update hypervisor ready condition#180

Merged
fwiesel merged 1 commit into
mainfrom
set-hypervisor-not-ready
Nov 17, 2025
Merged

HypervisorMaintenance: Update hypervisor ready condition#180
fwiesel merged 1 commit into
mainfrom
set-hypervisor-not-ready

Conversation

@fwiesel

@fwiesel fwiesel commented Nov 17, 2025

Copy link
Copy Markdown
Contributor

When we disable the hypervisor, it should be marked as not ready.

@fwiesel fwiesel requested a review from notandy November 17, 2025 15:38
Comment thread api/v1/hypervisor_types.go Outdated
@fwiesel fwiesel force-pushed the set-hypervisor-not-ready branch from 70f398d to 81c15cf Compare November 17, 2025 15:58
@fwiesel fwiesel requested a review from notandy November 17, 2025 15:59
When we disable the hypervisor, it should be marked as not ready.
@github-actions

Copy link
Copy Markdown

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/api/v1 0.00% (ø)
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller 34.56% (-3.76%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/api/v1/hypervisor_types.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/hypervisor_maintenance_controller.go 61.90% (+1.90%) 42 (+2) 26 (+2) 16 👍
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/onboarding_controller.go 2.79% (ø) 215 6 209

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/hypervisor_maintenance_controller_test.go

@fwiesel fwiesel merged commit f154d9e into main Nov 17, 2025
7 checks passed
@fwiesel fwiesel deleted the set-hypervisor-not-ready branch November 17, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants