Set GOMEMLIMIT from container memory limit#319
Conversation
|
Warning Review limit reached
More reviews will be available in 33 minutes and 3 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Without GOMEMLIMIT the Go GC is unaware of the container limit and may let the heap grow until the kernel OOM-kills the process.
There was a problem hiding this comment.
Pull request overview
This PR updates the Helm deployment for the controller-manager to set GOMEMLIMIT from the container’s configured memory limit so the Go GC can respect cgroup/container limits and reduce OOM-kill risk.
Changes:
- Add a
GOMEMLIMITenvironment variable to the controller-manager container, sourced fromlimits.memoryviaresourceFieldRef.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: GOMEMLIMIT | ||
| valueFrom: | ||
| resourceFieldRef: | ||
| resource: limits.memory |
Without
GOMEMLIMITthe Go GC is unaware of the container limit and maylet the heap grow until the kernel OOM-kills the process.