build: make markdownlint targets self-contained

the markdownlint and markdownlint.fix make targets
required markdownlint-cli2 to be installed locally
in the $PATH.

This change renders them self-contained by running
markdownlint from the official markdownlint-cli2
docker image.

Also clean the development-flow guide for linting tools

Signed-off-by: Michael Adam <obnox@samba.org>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Travis Nielsen <tnielsen@redhat.com>

Author: 3 people

Documentation/Contributing/development-flow.md

@@ -255,7 +255,6 @@ Run `make lint` to run all linters. This will require the following CLI tools to
 * [yamllint](https://www.yamllint.com/)
 * [shellcheck](https://www.shellcheck.net/)
 * [pylint](https://www.pylint.org/)
-* [markdownlint-cli2](https://github.com/DavidAnson/markdownlint-cli2)
 
 Many of those tools are available via `brew` for MacOS or as Linux distribution packages.
 Otherwise refer to the respective project websites for installation instructions.

Makefile

@@ -32,6 +32,7 @@ all: build
 CONTROLLER_GEN_VERSION=v0.19.0
 CT_VERSION := v3.13.0
 KUSTOMIZE_VERSION := v5.3.0
+MARKDOWNLINT_IMAGE_VERSION := v0.22.0
 
 # include here and not earlier so that the version numbers are available
 # where needed
@@ -188,11 +189,11 @@ golangci-lint: $(YQ)
 
 .PHONY: markdownlint
 markdownlint: ## Check formatting of documentation sources
-	markdownlint-cli2 "Documentation/**/**.md" "#Documentation/Helm-Charts/**" --config .markdownlint-cli2.cjs
+	@$(MARKDOWNLINT) "Documentation/**/**.md" "#Documentation/Helm-Charts/**" --config .markdownlint-cli2.cjs
 
 .PHONY: markdownlint.fix
 markdownlint.fix: ## Check and fix formatting of documentation sources
-	markdownlint-cli2 "Documentation/**/**.md" "#Documentation/Helm-Charts/**" --fix --config .markdownlint-cli2.cjs
+	@$(MARKDOWNLINT) "Documentation/**/**.md" "#Documentation/Helm-Charts/**" --fix --config .markdownlint-cli2.cjs
 
 .PHONY: yamllint
 yamllint:

build/makelib/common.mk

@@ -35,6 +35,8 @@ DOCKERCMD=$(shell podman version >/dev/null 2>&1 && echo podman)
 endif
 endif
 
+MARKDOWNLINT := $(DOCKERCMD) run --rm -v $$PWD:/workdir davidanson/markdownlint-cli2:$(MARKDOWNLINT_IMAGE_VERSION)
+
 ifeq ($(origin PLATFORM), undefined)
 ifeq ($(origin GOOS), undefined)
 GOOS := $(shell go env GOOS)