Commit 14da968
colexecerror: allow-list vecindex packages for panic catching
Previously, panics originating from the vecindex packages were not in
the colexecerror allow-list, causing them to crash the server instead
of being returned as SQL errors. For example, a dimension mismatch
query against a vector index would bring down the node.
The vecindex search path does not manipulate shared state or hold
in-memory locks in production (it uses KV-layer locking via vecstore),
so it is safe to catch these panics. Caught panics are returned as
assertion errors with sentry reports, preserving bug visibility without
crashing the server.
Resolves: #146694
Epic: none
Release note: None
Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>1 parent 18eb14f commit 14da968
1 file changed
Lines changed: 8 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
170 | 170 | | |
171 | 171 | | |
172 | 172 | | |
173 | | - | |
174 | | - | |
175 | | - | |
176 | | - | |
177 | | - | |
178 | | - | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
179 | 180 | | |
180 | 181 | | |
181 | 182 | | |
| |||
217 | 218 | | |
218 | 219 | | |
219 | 220 | | |
| 221 | + | |
220 | 222 | | |
221 | 223 | | |
222 | 224 | | |
| |||
0 commit comments