Skip to content

Commit 7cfaf47

Browse files
sqlproxy: move from pkg/ccl/sqlproxyccl to pkg/sqlproxy
The package had no actual CCL dependencies — the only ties were the no-op ccl.TestingEnableEnterprise() calls removed here. Rename package sqlproxyccl → sqlproxy, update all import paths, regenerate protos with the new package name, and update CODEOWNERS. Epic: none Release note: None Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
1 parent 3c98314 commit 7cfaf47

101 files changed

Lines changed: 152 additions & 160 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,7 @@
381381
/docs/generated/http/ @cockroachdb/obs-prs @cockroachdb/server-prs
382382
/pkg/cmd/docgen/http.go @cockroachdb/obs-prs @cockroachdb/server-prs
383383

384-
/pkg/ccl/sqlproxyccl/ @cockroachdb/sqlproxy-prs
384+
/pkg/sqlproxy/ @cockroachdb/sqlproxy-prs
385385

386386
/pkg/gen/ @cockroachdb/dev-inf
387387
#!/pkg/gen/*.bzl @cockroachdb/dev-inf-noreview

build/bazelutil/nogo_config.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,8 @@
6060
"pkg/ccl/changefeedccl/sink_kafka.go": "flagged by linter, should be evaluated",
6161
"pkg/ccl/changefeedccl/sink_pubsub_v2.go": "flagged by linter, should be evaluated",
6262
"pkg/ccl/multitenantccl/tenantcostclient/tenant_side.go": "flagged by linter, should be evaluated",
63-
"pkg/ccl/sqlproxyccl/acl/watcher.go": "flagged by linter, should be evaluated",
64-
"pkg/ccl/sqlproxyccl/tenantdirsvr/test_directory_svr.go": "flagged by linter, should be evaluated",
63+
"pkg/sqlproxy/acl/watcher.go": "flagged by linter, should be evaluated",
64+
"pkg/sqlproxy/tenantdirsvr/test_directory_svr.go": "flagged by linter, should be evaluated",
6565
"pkg/crosscluster/streamclient/random_stream_client.go": "flagged by linter, should be evaluated",
6666
"pkg/cli/clisqlexec/format_csv_tsv.go": "flagged by linter, should be evaluated",
6767
"pkg/cli/clisqlshell/sql.go": "flagged by linter, should be evaluated",

pkg/BUILD.bazel

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,6 @@ ALL_TESTS = [
5151
"//pkg/ccl/serverccl/diagnosticsccl:diagnosticsccl_test",
5252
"//pkg/ccl/serverccl/statusccl:statusccl_test",
5353
"//pkg/ccl/serverccl:serverccl_test",
54-
"//pkg/ccl/sqlproxyccl/acl:acl_test",
55-
"//pkg/ccl/sqlproxyccl/balancer:balancer_test",
56-
"//pkg/ccl/sqlproxyccl/interceptor:interceptor_test",
57-
"//pkg/ccl/sqlproxyccl/tenant:tenant_test",
58-
"//pkg/ccl/sqlproxyccl/throttler:throttler_test",
59-
"//pkg/ccl/sqlproxyccl:sqlproxyccl_test",
6054
"//pkg/ccl/testccl/authccl:authccl_test",
6155
"//pkg/ccl/testccl/sqlccl:sqlccl_test",
6256
"//pkg/ccl/testccl/sqlstatsccl:sqlstatsccl_test",
@@ -732,6 +726,12 @@ ALL_TESTS = [
732726
"//pkg/sql/zoneconfig:zoneconfig_test",
733727
"//pkg/sql:sql_disallowed_imports_test",
734728
"//pkg/sql:sql_test",
729+
"//pkg/sqlproxy/acl:acl_test",
730+
"//pkg/sqlproxy/balancer:balancer_test",
731+
"//pkg/sqlproxy/interceptor:interceptor_test",
732+
"//pkg/sqlproxy/tenant:tenant_test",
733+
"//pkg/sqlproxy/throttler:throttler_test",
734+
"//pkg/sqlproxy:sqlproxy_test",
735735
"//pkg/storage/disk:disk_test",
736736
"//pkg/storage/enginepb:enginepb_test",
737737
"//pkg/storage/fs:fs_test",
@@ -1038,19 +1038,6 @@ GO_TARGETS = [
10381038
"//pkg/ccl/serverccl/statusccl:statusccl_test",
10391039
"//pkg/ccl/serverccl:serverccl",
10401040
"//pkg/ccl/serverccl:serverccl_test",
1041-
"//pkg/ccl/sqlproxyccl/acl:acl",
1042-
"//pkg/ccl/sqlproxyccl/acl:acl_test",
1043-
"//pkg/ccl/sqlproxyccl/balancer:balancer",
1044-
"//pkg/ccl/sqlproxyccl/balancer:balancer_test",
1045-
"//pkg/ccl/sqlproxyccl/interceptor:interceptor",
1046-
"//pkg/ccl/sqlproxyccl/interceptor:interceptor_test",
1047-
"//pkg/ccl/sqlproxyccl/tenant:tenant",
1048-
"//pkg/ccl/sqlproxyccl/tenant:tenant_test",
1049-
"//pkg/ccl/sqlproxyccl/tenantdirsvr:tenantdirsvr",
1050-
"//pkg/ccl/sqlproxyccl/throttler:throttler",
1051-
"//pkg/ccl/sqlproxyccl/throttler:throttler_test",
1052-
"//pkg/ccl/sqlproxyccl:sqlproxyccl",
1053-
"//pkg/ccl/sqlproxyccl:sqlproxyccl_test",
10541041
"//pkg/ccl/testccl/authccl:authccl_test",
10551042
"//pkg/ccl/testccl/sqlccl:sqlccl_test",
10561043
"//pkg/ccl/testccl/sqlstatsccl:sqlstatsccl_test",
@@ -2707,6 +2694,19 @@ GO_TARGETS = [
27072694
"//pkg/sql/zoneconfig:zoneconfig_test",
27082695
"//pkg/sql:sql",
27092696
"//pkg/sql:sql_test",
2697+
"//pkg/sqlproxy/acl:acl",
2698+
"//pkg/sqlproxy/acl:acl_test",
2699+
"//pkg/sqlproxy/balancer:balancer",
2700+
"//pkg/sqlproxy/balancer:balancer_test",
2701+
"//pkg/sqlproxy/interceptor:interceptor",
2702+
"//pkg/sqlproxy/interceptor:interceptor_test",
2703+
"//pkg/sqlproxy/tenant:tenant",
2704+
"//pkg/sqlproxy/tenant:tenant_test",
2705+
"//pkg/sqlproxy/tenantdirsvr:tenantdirsvr",
2706+
"//pkg/sqlproxy/throttler:throttler",
2707+
"//pkg/sqlproxy/throttler:throttler_test",
2708+
"//pkg/sqlproxy:sqlproxy",
2709+
"//pkg/sqlproxy:sqlproxy_test",
27102710
"//pkg/storage/disk:disk",
27112711
"//pkg/storage/disk:disk_test",
27122712
"//pkg/storage/enginepb:enginepb",

pkg/ccl/testutilsccl/BUILD.bazel

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,7 @@ load("@io_bazel_rules_go//go:def.bzl", "go_library")
33
go_library(
44
name = "testutilsccl",
55
testonly = 1,
6-
srcs = [
7-
"alter_primary_key.go",
8-
],
6+
srcs = ["alter_primary_key.go"],
97
importpath = "github.com/cockroachdb/cockroach/pkg/ccl/testutilsccl",
108
visibility = ["//visibility:public"],
119
deps = [

pkg/cli/BUILD.bazel

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -127,9 +127,6 @@ go_library(
127127
deps = [
128128
"//pkg/base",
129129
"//pkg/build",
130-
"//pkg/ccl/sqlproxyccl",
131-
"//pkg/ccl/sqlproxyccl/tenant",
132-
"//pkg/ccl/sqlproxyccl/tenantdirsvr",
133130
"//pkg/cli/clicfg",
134131
"//pkg/cli/clientflags",
135132
"//pkg/cli/clienturl",
@@ -215,6 +212,9 @@ go_library(
215212
"//pkg/sql/sem/tree",
216213
"//pkg/sql/sqlstats",
217214
"//pkg/sql/stats",
215+
"//pkg/sqlproxy",
216+
"//pkg/sqlproxy/tenant",
217+
"//pkg/sqlproxy/tenantdirsvr",
218218
"//pkg/storage",
219219
"//pkg/storage/enginepb",
220220
"//pkg/storage/fs",

pkg/cli/mt_http_test_directory.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ import (
1414
"os"
1515
"os/signal"
1616

17-
"github.com/cockroachdb/cockroach/pkg/ccl/sqlproxyccl/tenant"
18-
"github.com/cockroachdb/cockroach/pkg/ccl/sqlproxyccl/tenantdirsvr"
1917
"github.com/cockroachdb/cockroach/pkg/cli/clierrorplus"
2018
"github.com/cockroachdb/cockroach/pkg/roachpb"
19+
"github.com/cockroachdb/cockroach/pkg/sqlproxy/tenant"
20+
"github.com/cockroachdb/cockroach/pkg/sqlproxy/tenantdirsvr"
2121
"github.com/cockroachdb/cockroach/pkg/util/log"
2222
"github.com/cockroachdb/cockroach/pkg/util/stop"
2323
"github.com/cockroachdb/cockroach/pkg/util/timeutil"

pkg/cli/mt_proxy.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ import (
1313
"os/signal"
1414
"time"
1515

16-
"github.com/cockroachdb/cockroach/pkg/ccl/sqlproxyccl"
1716
"github.com/cockroachdb/cockroach/pkg/cli/clierrorplus"
17+
"github.com/cockroachdb/cockroach/pkg/sqlproxy"
1818
"github.com/cockroachdb/cockroach/pkg/util/log"
1919
"github.com/cockroachdb/cockroach/pkg/util/log/severity"
2020
"github.com/cockroachdb/cockroach/pkg/util/stop"
@@ -74,7 +74,7 @@ func runStartSQLProxy(cmd *cobra.Command, args []string) (returnErr error) {
7474
}
7575
stopper.AddCloser(stop.CloserFn(func() { _ = metricsLn.Close() }))
7676

77-
server, err := sqlproxyccl.NewServer(ctx, stopper, proxyContext)
77+
server, err := sqlproxy.NewServer(ctx, stopper, proxyContext)
7878
if err != nil {
7979
return err
8080
}
@@ -115,7 +115,7 @@ func initProxyLogging(cmd *cobra.Command) (ctx context.Context, stopper *stop.St
115115

116116
func waitForProxySignals(
117117
ctx context.Context,
118-
server *sqlproxyccl.Server,
118+
server *sqlproxy.Server,
119119
stopper *stop.Stopper,
120120
proxyLn net.Listener,
121121
proxyProtocolLn net.Listener,

pkg/cli/mt_proxy_context.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ package cli
88
import (
99
"time"
1010

11-
"github.com/cockroachdb/cockroach/pkg/ccl/sqlproxyccl"
11+
"github.com/cockroachdb/cockroach/pkg/sqlproxy"
1212
)
1313

1414
func init() {
@@ -18,7 +18,7 @@ func init() {
1818
}
1919

2020
// proxyContext captures the command-line parameters of the `mt start-proxy` command.
21-
var proxyContext sqlproxyccl.ProxyOptions
21+
var proxyContext sqlproxy.ProxyOptions
2222

2323
func setProxyContextDefaults() {
2424
proxyContext.Denylist = ""

pkg/cli/mt_test_directory.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ import (
1717
"strings"
1818
"time"
1919

20-
"github.com/cockroachdb/cockroach/pkg/ccl/sqlproxyccl/tenantdirsvr"
2120
"github.com/cockroachdb/cockroach/pkg/cli/clierrorplus"
21+
"github.com/cockroachdb/cockroach/pkg/sqlproxy/tenantdirsvr"
2222
"github.com/cockroachdb/cockroach/pkg/util/log"
2323
"github.com/cockroachdb/cockroach/pkg/util/stop"
2424
"github.com/cockroachdb/cockroach/pkg/util/timeutil"

pkg/gen/protobuf.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ PROTOBUF_SRCS = [
1212
"//pkg/build:build_go_proto",
1313
"//pkg/ccl/changefeedccl/cdcprogresspb:cdcprogresspb_go_proto",
1414
"//pkg/ccl/changefeedccl/changefeedpb:changefeedpb_go_proto",
15-
"//pkg/ccl/sqlproxyccl/tenant:tenant_go_proto",
1615
"//pkg/changefeed/changefeedpb:changefeedpb_go_proto",
1716
"//pkg/cloud/cloudpb:cloudpb_go_proto",
1817
"//pkg/cloud/externalconn/connectionpb:connectionpb_go_proto",
@@ -90,6 +89,7 @@ PROTOBUF_SRCS = [
9089
"//pkg/sql/vecindex/cspann:cspann_go_proto",
9190
"//pkg/sql/vecindex/vecpb:vecpb_go_proto",
9291
"//pkg/sql/vecindex/vecstore/vecstorepb:vecstorepb_go_proto",
92+
"//pkg/sqlproxy/tenant:tenant_go_proto",
9393
"//pkg/storage/enginepb:enginepb_go_proto",
9494
"//pkg/testutils/grpcutils:grpcutils_go_proto",
9595
"//pkg/ts/catalog:catalog_go_proto",

0 commit comments

Comments
 (0)