sql: add system.vcpu_usage table (#170328)

sql: add system.vcpu_usage table

Author: trunk-io[bot]

docs/generated/settings/settings-for-tenants.txt

@@ -449,4 +449,4 @@ trace.zipkin.collector	string		the address of a Zipkin instance to receive trace
 ui.database_locality_metadata.enabled	boolean	true	if enabled shows extended locality data about databases and tables in DB Console which can be expensive to compute	application
 ui.default_timezone	string		the default timezone used to format timestamps in the ui	application
 ui.display_timezone	enumeration	etc/utc	the timezone used to format timestamps in the ui. This setting is deprecatedand will be removed in a future version. Use the 'ui.default_timezone' setting instead. 'ui.default_timezone' takes precedence over this setting. [etc/utc = 0, america/new_york = 1]	application
-version	version	1000026.2-upgrading-to-1000026.3-step-014	set the active cluster version in the format '<major>.<minor>'	application
+version	version	1000026.2-upgrading-to-1000026.3-step-016	set the active cluster version in the format '<major>.<minor>'	application

docs/generated/settings/settings.html

@@ -410,6 +410,6 @@
 <tr><td><div id="setting-ui-database-locality-metadata-enabled" class="anchored"><code>ui.database_locality_metadata.enabled</code></div></td><td>boolean</td><td><code>true</code></td><td>if enabled shows extended locality data about databases and tables in DB Console which can be expensive to compute</td><td>Basic/Standard/Advanced/Self-Hosted</td></tr>
 <tr><td><div id="setting-ui-default-timezone" class="anchored"><code>ui.default_timezone</code></div></td><td>string</td><td><code></code></td><td>the default timezone used to format timestamps in the ui</td><td>Basic/Standard/Advanced/Self-Hosted</td></tr>
 <tr><td><div id="setting-ui-display-timezone" class="anchored"><code>ui.display_timezone</code></div></td><td>enumeration</td><td><code>etc/utc</code></td><td>the timezone used to format timestamps in the ui. This setting is deprecatedand will be removed in a future version. Use the &#39;ui.default_timezone&#39; setting instead. &#39;ui.default_timezone&#39; takes precedence over this setting. [etc/utc = 0, america/new_york = 1]</td><td>Basic/Standard/Advanced/Self-Hosted</td></tr>
-<tr><td><div id="setting-version" class="anchored"><code>version</code></div></td><td>version</td><td><code>1000026.2-upgrading-to-1000026.3-step-014</code></td><td>set the active cluster version in the format &#39;&lt;major&gt;.&lt;minor&gt;&#39;</td><td>Basic/Standard/Advanced/Self-Hosted</td></tr>
+<tr><td><div id="setting-version" class="anchored"><code>version</code></div></td><td>version</td><td><code>1000026.2-upgrading-to-1000026.3-step-016</code></td><td>set the active cluster version in the format &#39;&lt;major&gt;.&lt;minor&gt;&#39;</td><td>Basic/Standard/Advanced/Self-Hosted</td></tr>
 </tbody>
 </table>

pkg/backup/full_cluster_backup_restore_test.go

@@ -724,6 +724,7 @@ func TestClusterRestoreFailCleanup(t *testing.T) {
 				{"tenant_settings"},
 				{"ui"},
 				{"users"},
+				{"vcpu_usage"},
 				{"zones"},
 			},
 		)
@@ -822,6 +823,7 @@ func TestClusterRestoreFailCleanup(t *testing.T) {
 				{"tenant_settings"},
 				{"ui"},
 				{"users"},
+				{"vcpu_usage"},
 				{"zones"},
 			},
 		)

pkg/backup/system_schema.go

@@ -989,6 +989,9 @@ var systemTableBackupConfiguration = map[string]systemBackupConfiguration{
 		// Restore after system.resource_groups so we can read max(id).
 		restoreInOrder: 1,
 	},
+	systemschema.VcpuUsageTable.GetName(): {
+		shouldIncludeInClusterBackup: optInToClusterBackup,
+	},
 }
 
 func resourceGroupIDSeqRestoreFunc(

pkg/backup/testdata/backup-restore/external-connections-nodelocal

@@ -58,6 +58,7 @@ statements table full
 system database full
 ui table full
 users table full
+vcpu_usage table full
 zones table full
 
 # Database backup.

pkg/backup/testdata/backup-restore/external-connections-userfile

@@ -60,6 +60,7 @@ ui table full
 userfiles_root_upload_files table full
 userfiles_root_upload_payload table full
 users table full
+vcpu_usage table full
 zones table full
 
 # Database backup.

pkg/cli/testdata/doctor/test_examine_cluster

@@ -1,7 +1,7 @@
 debug doctor examine cluster
 ----
 debug doctor examine cluster
-Examining 79 descriptors and 78 namespace entries...
+Examining 80 descriptors and 79 namespace entries...
   ParentID 100, ParentSchemaID 101: relation "foo" (105): expected matching namespace entry, found none
 Examining 12 jobs...
 ERROR: validation failed

pkg/cli/testdata/doctor/test_examine_cluster_dropped

@@ -1,6 +1,6 @@
 debug doctor examine cluster
 ----
 debug doctor examine cluster
-Examining 78 descriptors and 78 namespace entries...
+Examining 79 descriptors and 79 namespace entries...
 Examining 10 jobs...
 No problems found!

pkg/cli/testdata/doctor/test_examine_cluster_jobs

@@ -1,7 +1,7 @@
 debug doctor examine cluster
 ----
 debug doctor examine cluster
-Examining 78 descriptors and 79 namespace entries...
+Examining 79 descriptors and 80 namespace entries...
   ParentID 183, ParentSchemaID 381: relation "foo" (104): referenced database ID 183: referenced descriptor not found
   ParentID 183, ParentSchemaID 381: relation "foo" (104): referenced schema ID 381: referenced descriptor not found
   ParentID 183, ParentSchemaID 381: relation "foo" (104): expected matching namespace entry, found none

pkg/cli/zip_table_registry.go

@@ -1302,6 +1302,7 @@ var disabledSystemTables = map[string]struct{}{
 	"system.transaction_statistics":         {},
 	"system.ui":                             {},
 	"system.users":                          {},
+	"system.vcpu_usage":                     {},
 	"system.web_sessions":                   {},
 }