Skip to content

Commit a299f8e

Browse files
backup: fix flaky TestOnlineRestoreDistFlowSplitScatter (#168294)
backup: fix flaky TestOnlineRestoreDistFlowSplitScatter
2 parents 3e3576a + 39df8e1 commit a299f8e

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

pkg/backup/restore_online_distflow_test.go

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,13 @@ import (
1515
"github.com/cockroachdb/cockroach/pkg/backup/backuppb"
1616
"github.com/cockroachdb/cockroach/pkg/base"
1717
"github.com/cockroachdb/cockroach/pkg/cloud/nodelocal"
18+
"github.com/cockroachdb/cockroach/pkg/jobs"
1819
"github.com/cockroachdb/cockroach/pkg/jobs/jobspb"
1920
"github.com/cockroachdb/cockroach/pkg/kv/kvpb"
2021
"github.com/cockroachdb/cockroach/pkg/kv/kvserver"
2122
"github.com/cockroachdb/cockroach/pkg/sql"
2223
"github.com/cockroachdb/cockroach/pkg/sql/execinfra"
24+
"github.com/cockroachdb/cockroach/pkg/testutils"
2325
"github.com/cockroachdb/cockroach/pkg/testutils/jobutils"
2426
"github.com/cockroachdb/cockroach/pkg/testutils/serverutils"
2527
"github.com/cockroachdb/cockroach/pkg/testutils/sqlutils"
@@ -113,6 +115,7 @@ func TestOnlineRestoreDistFlowSplitScatter(t *testing.T) {
113115
},
114116
},
115117
},
118+
JobsTestingKnobs: jobs.NewTestingKnobsWithShortIntervals(),
116119
},
117120
})
118121

@@ -171,7 +174,10 @@ func TestOnlineRestoreDistFlowSplitScatter(t *testing.T) {
171174
var downloadJobID jobspb.JobID
172175
runner.QueryRow(t, latestDownloadJobIDQuery).Scan(&downloadJobID)
173176
runner.Exec(t, "SET CLUSTER SETTING jobs.debug.pausepoints = ''")
174-
runner.Exec(t, fmt.Sprintf("CANCEL JOB %d", downloadJobID))
177+
testutils.SucceedsSoon(t, func() error {
178+
_, err := sqlDB.Exec(fmt.Sprintf("CANCEL JOB %d", downloadJobID))
179+
return err
180+
})
175181
jobutils.WaitForJobToCancel(t, runner, downloadJobID)
176182
runner.Exec(t, "SET CLUSTER SETTING jobs.debug.pausepoints = 'restore.before_download'")
177183
}

0 commit comments

Comments
 (0)