release-25.2: backupsink: drop pretty.Formatter log that crashes on Azure errors (#169702)

trunk-io[bot] · web-flow · commit b897d857d6a5 · 2026-05-05T17:50:30.000Z
release-25.2: backupsink: drop pretty.Formatter log that crashes on Azure errors
diff --git a/pkg/backup/backupsink/BUILD.bazel b/pkg/backup/backupsink/BUILD.bazel
@@ -26,7 +26,6 @@ go_library(
         "//pkg/util/unique",
         "@com_github_cockroachdb_errors//:errors",
         "@com_github_gogo_protobuf//types",
-        "@com_github_kr_pretty//:pretty",
     ],
 )
 
diff --git a/pkg/backup/backupsink/file_sst_sink.go b/pkg/backup/backupsink/file_sst_sink.go
@@ -25,7 +25,6 @@ import (
 	"github.com/cockroachdb/cockroach/pkg/util/log"
 	"github.com/cockroachdb/errors"
 	gogotypes "github.com/gogo/protobuf/types"
-	"github.com/kr/pretty"
 )
 
 var (
@@ -280,7 +279,6 @@ func (s *FileSSTSink) Flush(ctx context.Context) error {
 		return err
 	}
 	if err := s.out.Close(); err != nil {
-		log.Warningf(ctx, "failed to close write in FileSSTSink: % #v", pretty.Formatter(err))
 		return errors.Wrap(err, "writing SST")
 	}
 	wroteSize := s.sst.Meta.Size

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,6 @@ go_library(`
`26`	`26`	`"//pkg/util/unique",`
`27`	`27`	`"@com_github_cockroachdb_errors//:errors",`
`28`	`28`	`"@com_github_gogo_protobuf//types",`
`29`		`- "@com_github_kr_pretty//:pretty",`
`30`	`29`	`],`
`31`	`30`	`)`
`32`	`31`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,6 @@ import (`
`25`	`25`	`"github.com/cockroachdb/cockroach/pkg/util/log"`
`26`	`26`	`"github.com/cockroachdb/errors"`
`27`	`27`	`gogotypes "github.com/gogo/protobuf/types"`
`28`		`- "github.com/kr/pretty"`
`29`	`28`	`)`
`30`	`29`
`31`	`30`	`var (`
`@@ -280,7 +279,6 @@ func (s *FileSSTSink) Flush(ctx context.Context) error {`
`280`	`279`	`return err`
`281`	`280`	`}`
`282`	`281`	`if err := s.out.Close(); err != nil {`
`283`		`- log.Warningf(ctx, "failed to close write in FileSSTSink: % #v", pretty.Formatter(err))`
`284`	`282`	`return errors.Wrap(err, "writing SST")`
`285`	`283`	`}`
`286`	`284`	`wroteSize := s.sst.Meta.Size`