Skip to content

Commit cedf088

Browse files
obs: make codeowner_count cluster setting non-public (#167492)
obs: make codeowner_count cluster setting non-public
2 parents dc6bfdd + 2897eb4 commit cedf088

3 files changed

Lines changed: 1 addition & 4 deletions

File tree

docs/generated/settings/settings-for-tenants.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,6 @@ kv.transaction.write_pipelining.ranged_writes.enabled boolean true if enabled, t
113113
kv.transaction.write_pipelining.enabled (alias: kv.transaction.write_pipelining_enabled) boolean true if enabled, transactional writes are pipelined through Raft consensus application
114114
kv.transaction.write_pipelining.max_batch_size (alias: kv.transaction.write_pipelining_max_batch_size) integer 128 if non-zero, defines that maximum size batch that will be pipelined through Raft consensus application
115115
log.channel_compatibility_mode.enabled boolean false when true, logs will to log to their legacy (pre 26.1) logging channels; when false, logs will be logged to new logging channels application
116-
obs.metric_export.codeowner_count.enabled boolean false enables the reporting of per-CODEOWNER metric counts in the Prometheus scrape application
117116
obs.metrics_scrape.default_visibility enumeration all controls the default metric visibility level for the metrics scrape endpoints [internal = -1, all = 0, support = 1, essential = 2] application
118117
obs.tablemetadata.automatic_updates.enabled boolean false enables automatic updates of the table metadata cache system.table_metadata application
119118
obs.tablemetadata.data_valid_duration duration 20m0s the duration for which the data in system.table_metadata is considered valid application

docs/generated/settings/settings.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,6 @@
145145
<tr><td><div id="setting-kvadmission-store-snapshot-ingest-bandwidth-control-enabled" class="anchored"><code>kvadmission.store.snapshot_ingest_bandwidth_control.enabled</code></div></td><td>boolean</td><td><code>true</code></td><td>if set to true, snapshot ingests will be subject to disk write control in AC</td><td>Advanced/Self-Hosted</td></tr>
146146
<tr><td><div id="setting-kvadmission-store-snapshot-ingest-bandwidth-control-min-rate-enabled" class="anchored"><code>kvadmission.store.snapshot_ingest_bandwidth_control.min_rate.enabled</code></div></td><td>boolean</td><td><code>true</code></td><td>if set to true, snapshot ingests will be admitted at a minimum rate when kvadmission.store.provisioned_bandwidth is set to a non-zero value. Disabling this setting can lead to snapshots being starved out by foreground traffic.</td><td>Advanced/Self-Hosted</td></tr>
147147
<tr><td><div id="setting-log-channel-compatibility-mode-enabled" class="anchored"><code>log.channel_compatibility_mode.enabled</code></div></td><td>boolean</td><td><code>false</code></td><td>when true, logs will to log to their legacy (pre 26.1) logging channels; when false, logs will be logged to new logging channels</td><td>Basic/Standard/Advanced/Self-Hosted</td></tr>
148-
<tr><td><div id="setting-obs-metric-export-codeowner-count-enabled" class="anchored"><code>obs.metric_export.codeowner_count.enabled</code></div></td><td>boolean</td><td><code>false</code></td><td>enables the reporting of per-CODEOWNER metric counts in the Prometheus scrape</td><td>Basic/Standard/Advanced/Self-Hosted</td></tr>
149148
<tr><td><div id="setting-obs-metrics-scrape-default-visibility" class="anchored"><code>obs.metrics_scrape.default_visibility</code></div></td><td>enumeration</td><td><code>all</code></td><td>controls the default metric visibility level for the metrics scrape endpoints [internal = -1, all = 0, support = 1, essential = 2]</td><td>Basic/Standard/Advanced/Self-Hosted</td></tr>
150149
<tr><td><div id="setting-obs-tablemetadata-automatic-updates-enabled" class="anchored"><code>obs.tablemetadata.automatic_updates.enabled</code></div></td><td>boolean</td><td><code>false</code></td><td>enables automatic updates of the table metadata cache system.table_metadata</td><td>Basic/Standard/Advanced/Self-Hosted</td></tr>
151150
<tr><td><div id="setting-obs-tablemetadata-data-valid-duration" class="anchored"><code>obs.tablemetadata.data_valid_duration</code></div></td><td>duration</td><td><code>20m0s</code></td><td>the duration for which the data in system.table_metadata is considered valid</td><td>Basic/Standard/Advanced/Self-Hosted</td></tr>

pkg/server/status/recorder.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,8 +128,7 @@ var ChildMetricsStorageEnabled = settings.RegisterBoolSetting(
128128
var codeownerMetricCountEnabled = settings.RegisterBoolSetting(
129129
settings.ApplicationLevel, "obs.metric_export.codeowner_count.enabled",
130130
"enables the reporting of per-CODEOWNER metric counts in the Prometheus scrape",
131-
false,
132-
settings.WithPublic)
131+
false)
133132

134133
// ScrapeMetrics holds meta-metrics that describe the volume of a Prometheus
135134
// scrape. They are updated at the end of each /_status/vars scrape cycle and

0 commit comments

Comments
 (0)