metric: embed source file in Metadata for CODEOWNERS resolution

BUILD.bazel

@@ -205,6 +205,7 @@ nogo(
         "//pkg/testutils/lint/passes/grpcstatuswithdetails",
         "//pkg/testutils/lint/passes/hash",
         "//pkg/testutils/lint/passes/leaktestcall",
+        "//pkg/testutils/lint/passes/metricmetadatainit",
         "//pkg/testutils/lint/passes/nilness",
         "//pkg/testutils/lint/passes/nocopy",
         "//pkg/testutils/lint/passes/redactcheck",

build/bazelutil/nogo_config.json

@@ -1654,5 +1654,16 @@
             "external/": "exclude all third-party code for all analyzers",
             "pkg/sql/colexec/colexechash/hash\\.go$": "re-implements runtime.noescape for efficient hashing"
         }
+    },
+    "metricmetadatainit": {
+        "exclude_files": {
+            "external/": "exclude all third-party code",
+            ".*\\.pb\\.go$": "generated code",
+            ".*\\.pb\\.gw\\.go$": "generated code",
+            "pkg/.*\\.eg\\.go$": "generated code",
+            "pkg/.*_generated\\.go$": "generated code",
+            "pkg/util/metric/.*\\.go$": "metric package internal usage is allowed",
+            "pkg/testutils/": "test utilities may construct Metadata for testing"
+        }
     }
 }

build/github/check-generated-code.sh

@@ -61,10 +61,6 @@ if grep TODO DEPS.bzl; then
 fi
 check_workspace_clean "Run \`./dev generate bazel\` to fix this error."
 
-# Run gen-metric-owners to ensure metric_owners.yaml is up to date
-# before //pkg/gen regenerates metrics.yaml from it.
-bazel run //pkg/cmd/gen-metric-owners $ENGFLOW_ARGS -- -out="$(pwd)/pkg/internal/metricscan/metric_owners.yaml"
-
 # Run `bazel run //pkg/gen` and ensure nothing changes. This ensures
 # generated documentation and checked-in go code are up to date.
 bazel run //pkg/gen $ENGFLOW_ARGS

docs/generated/metrics/BUILD.bazel

@@ -1,10 +1,7 @@
 genrule(
     name = "metrics",
-    srcs = [
-        "//pkg/internal/metricscan:metric_owners.yaml",
-    ],
     outs = ["metrics.yaml"],
-    cmd = "$(location //pkg/cmd/cockroach-short) gen metric-list --logtostderr=NONE --metric-owners=$(location //pkg/internal/metricscan:metric_owners.yaml) > $@",
+    cmd = "$(location //pkg/cmd/cockroach-short) gen metric-list --logtostderr=NONE > $@",
     tools = ["//pkg/cmd/cockroach-short"],
     visibility = [
         ":__pkg__",