sql/importer: further split TestImportIntoCSV to avoid shard timeout#167500
Open
mw5h wants to merge 1 commit intocockroachdb:masterfrom
Open
sql/importer: further split TestImportIntoCSV to avoid shard timeout#167500mw5h wants to merge 1 commit intocockroachdb:masterfrom
mw5h wants to merge 1 commit intocockroachdb:masterfrom
Conversation
TestImportIntoCSV contained 22 subtests (~15 success cases at ~60s each) that collectively took ~15 minutes. When colocated with other tests on the same Bazel shard, this exceeded the 15-minute timeout. Split TestImportIntoCSV into three top-level functions so Bazel can distribute them across shards: - TestImportIntoCSV: basic import and options tests (6 cases) - TestImportIntoCSVCompress: gzip/bzip compression and wildcard tests (9 cases) - TestImportIntoCSVErrors: error handling tests (7 cases) Extract the shared test loop body into runImportIntoCSVTestCases to avoid duplicating the ~70-line loop body across the three functions. Resolves: cockroachdb#165847 Epic: none Release note: None
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Member
|
This change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestImportIntoCSV contained 22 subtests (~15 success cases at ~60s each)
that collectively took ~15 minutes. When colocated with other tests on
the same Bazel shard, this exceeded the 15-minute timeout.
Split TestImportIntoCSV into three top-level functions so Bazel can
distribute them across shards:
The shared test loop body is extracted into
runImportIntoCSVTestCasesto avoid duplicating it across the three functions.
Resolves: #165847
Epic: none
Release note: None