kvstorage/wag: prepare for WAG truncation#167527
Merged
Merged
Conversation
Contributor
|
😎 Merged successfully - details. |
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
iskettaneh
force-pushed
the
rse_truncate
branch
2 times, most recently
from
April 4, 2026 14:06
141c29b to
16c01b7
Compare
iskettaneh
marked this pull request as ready for review
April 6, 2026 13:17
pav-kv
reviewed
Apr 6, 2026
pav-kv
left a comment
pav-kv
left a comment
Collaborator
There was a problem hiding this comment.
LGTM % adding tests. Please make the PR description well formatted too.
pav-kv
approved these changes
Apr 6, 2026
pav-kv
reviewed
Apr 6, 2026
iskettaneh
force-pushed
the
rse_truncate
branch
2 times, most recently
from
April 6, 2026 18:55
3c0333c to
d058af5
Compare
Contributor
Author
|
/trunk merge |
This commit sets up the premitives for WAG truncations by: 1) Adding a `Delete` function for removing WAG nodes by index. 2) Changing the WAG `Iterator.Iter` method to return `iter.Seq2[uint64, wagpb.Node]` pair. This will be useful when we iterate over the WAG and truncate the nodes that have been applied and synced. Epic: none Release note: None Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
Contributor
Author
|
/trunk merge |
Contributor
Author
|
/trunk merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit sets up the premitives for WAG truncations by:
Deletefunction for removing WAG nodes by index.Iterator.Itermethod to returniter.Seq2[uint64, wagpb.Node]pair. This will be useful when we iterate over the WAG and truncate the nodes that have been applied and synced.References: #167607
Release note: None