kvstorage: add WAG truncation infrastructure#167533
Draft
iskettaneh wants to merge 2 commits intocockroachdb:masterfrom
Draft
kvstorage: add WAG truncation infrastructure#167533iskettaneh wants to merge 2 commits intocockroachdb:masterfrom
iskettaneh wants to merge 2 commits intocockroachdb:masterfrom
Conversation
This commit sets up the premitives for WAG truncations by: 1) Adding a `Delete` function for removing WAG nodes by index. 2) Changing the WAG `Iterator.Iter` method to return `iter.Seq2[uint64, wagpb.Node]` pair. This will be useful when we iterate over the WAG and truncate the nodes that have been applied and synced. Epic: none Release note: None Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Member
|
This change is |
This PR adds the infrastructure that will be used to truncating WAG nodes. It will be used in two places: 1) Truncating all WAG nodes on startup, and 2) Periodically truncating durably applied WAG nodes. A lot of functions are similar to WAG replay, and there are TODOs to reconcile the functions between WAG replay and truncation. There is also some work left for clearing the Raft state, and deleting sideloaded files. Release note: None Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com> kvstorage/wag: prepare for WAG truncation This commit sets up the premitives for WAG truncations by: 1) Adding a `Delete` function for removing WAG nodes by index. 2) Changing the WAG `Iterator.Iter` method to return `iter.Seq2[uint64, wagpb.Node]` pair. This will be useful when we iterate over the WAG and truncate the nodes that have been applied and synced. Epic: none Release note: None Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
iskettaneh
force-pushed
the
rse_truncate_2
branch
from
66d1a39 to
7755a41
Compare
iskettaneh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit is based on #167527
This PR adds the infrastructure that will be used to truncating WAG
nodes. It will be used in two places: 1) Truncating all WAG nodes on
startup, and 2) Periodically truncating durably applied WAG nodes.
A lot of functions are similar to WAG replay, and there are TODOs to
reconcile the functions between WAG replay and truncation.
There is also some work left for clearing the Raft state, and deleting
sideloaded files.
Release note: None
Epic: None