release-26.2: roachtest: GCS failover for oversized artifacts.zip#170601
Open
williamchoe3 wants to merge 2 commits into
Open
release-26.2: roachtest: GCS failover for oversized artifacts.zip#170601williamchoe3 wants to merge 2 commits into
williamchoe3 wants to merge 2 commits into
Conversation
Previously, artifacts.zip was uploaded via the TeamCity publishArtifacts service message. TeamCity's artifact upload limit is 7GB, and some roachtests now produce artifacts.zip files far above that size. This change adds a GCS failover path for artifacts.zip when it reaches the configured threshold. Instead of uploading the large artifacts.zip to TeamCity, roachtest uploads it to GCS and replaces the local zip with a small artifacts.zip containing artifacts-failover.txt, which points to the GCS URI. Release note: None (cherry picked from commit 0f323e7)
Previously, artifact upload failover logs were written to per-test logs. Because failover logic runs after per-test Datadog upload, Datadog log monitors could not observe failover logs. In publishTeamCityArtifactsWithFailover, use the runner logger for failover diagnostics. Runner logs are uploaded to Datadog at the end of the roachtest run, so log monitors can observe artifact failover events. Release note: None (cherry picked from commit 8d6b376)
williamchoe3
added
the
backport
williamchoe3
requested review from
herkolategan and
shailendra-patel
and removed request for
a team
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
Thanks for opening a backport. Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate. |
Member
|
This change is |
blathers-crl
Bot
added
the
backport-test-only
herkolategan
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of:
0f323e7c9484bc3f5266f5020dbc4ea7f9554bee) roachtest: GCS failover for oversized artifacts.zip8d6b3763257cda023b948834f80f54bc74209d83) roachtest: log artifact failover to runner logsRelease justification: Test only changes
Epic: None