Skip to content

workload/schemachanger: expect competing drop error in operation generation #170605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bghal wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −4
Open

workload/schemachanger: expect competing drop error in operation generation #170605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions pkg/workload/schemachange/schemachange.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,11 +589,20 @@ func (w *schemaChangeWorker) runInTxn(

op, err := w.opGen.randOp(ctx, tx, useDeclarativeSchemaChanger, numOps)
if pgErr := new(pgconn.PgError); errors.As(err, &pgErr) {
// OutOfMemory (53200) is rollback-worthy: the workload's
// introspection queries can exhaust the server's per-query
// memory budget under load, which is not a workload bug.
switch pgcode.MakeCode(pgErr.Code) {
case pgcode.SerializationFailure, pgcode.OutOfMemory:
// These errors are rollback-worthy.
//
// OutOfMemory: introspection queries can exceed the per-query
// memory budget under load.
//
// Undefined*: A concurrent DROP can remove a descriptor while an
// operation is generated against it, aborting the server-side
// transaction.
case pgcode.SerializationFailure,
pgcode.OutOfMemory,
pgcode.UndefinedTable, pgcode.UndefinedDatabase,
pgcode.UndefinedSchema, pgcode.UndefinedObject,
pgcode.UndefinedFunction:
return errors.Mark(err, errRunInTxnRbkSentinel)
}
}
Expand Down
Loading