Skip to content

release-26.2: kvserver: deflake TestCrashWhileTruncatingSideloadedEntries#170637

Merged
trunk-io[bot] merged 1 commit into
release-26.2from
blathers/backport-release-26.2-170631
May 26, 2026
Merged

release-26.2: kvserver: deflake TestCrashWhileTruncatingSideloadedEntries#170637
trunk-io[bot] merged 1 commit into
release-26.2from
blathers/backport-release-26.2-170631

Conversation

@blathers-crl

@blathers-crl blathers-crl Bot commented May 20, 2026

Copy link
Copy Markdown

Backport 1/1 commits from #170631 on behalf of @pav-kv.


The test manually emulated a crash by tripping circuit breakers on the follower's dialer, taking a CrashClone, and stopping the server.

However, circuit breakers only block the follower's outgoing traffic — the leader can still send messages to the follower via the leader's own connection/stream. This caused a flake where the follower received and acknowledged a raft entry that wasn't synced to disk before CrashClone, leading to a panic on restart.

Replace the manual crash emulation with the canonical tc.CrashNode(), which uses rpc.Partitioner to add bidirectional partitions before taking the crash snapshot, blocking all traffic.

Informs #170454
Fixes #117785

Epic: none
Release note: None


Release justification: test deflake

@blathers-crl blathers-crl Bot requested a review from a team as a code owner May 20, 2026 13:38
@blathers-crl blathers-crl Bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels May 20, 2026
@trunk-io

trunk-io Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details.

@blathers-crl blathers-crl Bot requested a review from miraradeva May 20, 2026 13:38
@blathers-crl

blathers-crl Bot commented May 20, 2026

Copy link
Copy Markdown
Author

Thanks for opening a backport.

Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate.

@blathers-crl blathers-crl Bot added backport Label PR's that are backports to older release branches T-kv KV Team labels May 20, 2026
@cockroach-teamcity

Copy link
Copy Markdown
Member

This change is Reviewable

@blathers-crl blathers-crl Bot added the backport-test-only Used to denote the backport has only non-production changes label May 20, 2026
@pav-kv

pav-kv commented May 21, 2026

Copy link
Copy Markdown
Collaborator

Holding off the merge since there is some race in maybe_stressrace to fix first.

The test manually emulated a crash by tripping circuit breakers on the
follower's dialer, taking a CrashClone, and stopping the server.

However, circuit breakers only block the follower's outgoing traffic —
the leader can still send messages to the follower via the leader's own
connection/stream. This caused a flake where the follower received and
acknowledged a raft entry that wasn't synced to disk before CrashClone,
leading to a panic on restart.

Replace the manual crash emulation with the canonical tc.CrashNode(),
which uses rpc.Partitioner to add bidirectional partitions before taking
the crash snapshot, blocking all traffic.

Epic: none
Release note: None

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@pav-kv pav-kv force-pushed the blathers/backport-release-26.2-170631 branch from 347d87e to 2c38997 Compare May 26, 2026 07:52
@pav-kv

pav-kv commented May 26, 2026

Copy link
Copy Markdown
Collaborator

CI should be fixed after #170893

@trunk-io trunk-io Bot merged commit 4e5791c into release-26.2 May 26, 2026
18 checks passed
@trunk-io trunk-io Bot deleted the blathers/backport-release-26.2-170631 branch May 26, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches backport-test-only Used to denote the backport has only non-production changes blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-kv KV Team v26.2.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants