release-26.2: kvserver: deflake TestCrashWhileTruncatingSideloadedEntries#170637
Conversation
|
😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details. |
|
Thanks for opening a backport. Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate. |
|
Holding off the merge since there is some race in |
The test manually emulated a crash by tripping circuit breakers on the follower's dialer, taking a CrashClone, and stopping the server. However, circuit breakers only block the follower's outgoing traffic — the leader can still send messages to the follower via the leader's own connection/stream. This caused a flake where the follower received and acknowledged a raft entry that wasn't synced to disk before CrashClone, leading to a panic on restart. Replace the manual crash emulation with the canonical tc.CrashNode(), which uses rpc.Partitioner to add bidirectional partitions before taking the crash snapshot, blocking all traffic. Epic: none Release note: None Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
347d87e to
2c38997
Compare
|
CI should be fixed after #170893 |
Backport 1/1 commits from #170631 on behalf of @pav-kv.
The test manually emulated a crash by tripping circuit breakers on the follower's dialer, taking a
CrashClone, and stopping the server.However, circuit breakers only block the follower's outgoing traffic — the leader can still send messages to the follower via the leader's own connection/stream. This caused a flake where the follower received and acknowledged a raft entry that wasn't synced to disk before
CrashClone, leading to a panic on restart.Replace the manual crash emulation with the canonical
tc.CrashNode(), which usesrpc.Partitionerto add bidirectional partitions before taking the crash snapshot, blocking all traffic.Informs #170454
Fixes #117785
Epic: none
Release note: None
Release justification: test deflake