Skip to content

sql: fix flaky TestIndexSplitAndScatterWithStats #170661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michae2 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sql: fix flaky TestIndexSplitAndScatterWithStats #170661

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pkg/sql/index_split_scatter_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import (
"github.com/cockroachdb/cockroach/pkg/config"
"github.com/cockroachdb/cockroach/pkg/keys"
"github.com/cockroachdb/cockroach/pkg/sql"
"github.com/cockroachdb/cockroach/pkg/sql/catalog/descpb"
"github.com/cockroachdb/cockroach/pkg/testutils"
"github.com/cockroachdb/cockroach/pkg/testutils/serverutils"
"github.com/cockroachdb/cockroach/pkg/testutils/skip"
Expand Down Expand Up @@ -165,6 +166,12 @@ func TestIndexSplitAndScatterWithStats(t *testing.T) {
// Generate statistics for these tables.
if statsExist {
runner.Exec(t, "CREATE STATISTICS st FROM multi_column_split")
// Force a stats cache refresh on all nodes so
// MaybeSplitIndexSpans sees the new stats.
tableID := descpb.ID(sqlutils.QueryTableID(t, cluster.ServerConn(0), "defaultdb", "public", "multi_column_split"))
for i := 0; i < numNodes; i++ {
cluster.Server(i).ExecutorConfig().(sql.ExecutorConfig).TableStatsCache.InvalidateTableStats(ctx, tableID)
}
}
// Next create indexes on both tables.
splitHookEnabled.Store(true)
Expand Down
Loading