roachtest: skip revision history in OR recovery test#170682
Open
kev-cao wants to merge 1 commit into
Open
Conversation
The OR recovery test deletes backup SSTs before the link phase to avoid the Pebble compaction race described in cockroachdb#170225. When the random backup options include `revision_history`, every file is forced through the ingest path during the link phase, which then tries to read the already-deleted SSTs and fails. Disable revision history for this test until cockroachdb#170681 makes the link path usable for revision-history backups when the restore time aligns with the backup chain's end time. Fixes: cockroachdb#170617 Release note: None Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Member
|
This change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OR recovery test deletes backup SSTs before the link phase to avoid
the Pebble compaction race described in #170225. When the random backup
options include
revision_history, every file is forced through theingest path during the link phase, which then tries to read the
already-deleted SSTs and fails.
Disable revision history for this test until #170681 makes the link
path usable for revision-history backups when the restore time aligns
with the backup chain's end time.
Fixes: #170617
Release note: None
Co-Authored-By: roachdev-claude roachdev-claude-bot@cockroachlabs.com