Skip to content

release-25.4: roachprod: bump local Prometheus version to 2.53.5#170745

Merged
trunk-io[bot] merged 1 commit into
release-25.4from
blathers/backport-release-25.4-170676
May 21, 2026
Merged

release-25.4: roachprod: bump local Prometheus version to 2.53.5#170745
trunk-io[bot] merged 1 commit into
release-25.4from
blathers/backport-release-25.4-170676

Conversation

@blathers-crl

@blathers-crl blathers-crl Bot commented May 21, 2026

Copy link
Copy Markdown

Backport 1/1 commits from #170676 on behalf of @Dev-Kyle.


The local Prometheus version (2.27.1) is over 4 years old and has been observed crashing in CI (e.g. #169503 on s390x). This commit bumps it to 2.53.5, the latest patch in the 2.53 LTS series.

We choose to stay on 2.x instead of upgrading to 3.x to avoid any breaking changes. The 2.x bump is sufficient to address the stability issue mentioned above and will act as an drop-in replacement before we move away from Prometheus entirely (VictoriaMetrics).

The 2.53.5 tarballs have been uploaded to
gs://cockroach-test-artifacts/prometheus/ for amd64, arm64, and s390x. No testdata regeneration was required because PrometheusVersion is not embedded in any cloud-provider startup script.

Validation

Manually triggered admission-control/intent-resolution against this branch via TeamCity:

https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Nightlies_RoachtestNightlyGceBazel?branch=170676&buildTypeTab=overview&mode=builds

Resolves: #169559
See also: #169503

Release note: None


Release justification: Test only changes

The local Prometheus version (2.27.1)  is over 4 years old and has been
observed crashing in CI (e.g. #169503 on s390x). This commit bumps it to
2.53.5, the latest patch in the 2.53 LTS series.

We choose to stay on 2.x instead of upgrading to 3.x to avoid any
breaking changes. The 2.x bump is sufficient to address the stability
issue mentioned above and will act as an drop-in replacement before we
move away from Prometheus entirely (VictoriaMetrics).

The 2.53.5 tarballs have been uploaded to
gs://cockroach-test-artifacts/prometheus/ for amd64, arm64, and s390x.
No testdata regeneration was required because PrometheusVersion is not
embedded in any cloud-provider startup script.

Resolves: #169559
See also: #169503

Release note: None
@blathers-crl
blathers-crl Bot force-pushed the blathers/backport-release-25.4-170676 branch from e268f22 to 26b1c12 Compare May 21, 2026 15:54
@blathers-crl
blathers-crl Bot requested a review from a team as a code owner May 21, 2026 15:54
@blathers-crl
blathers-crl Bot requested review from cpj2195 and williamchoe3 and removed request for a team May 21, 2026 15:54
@blathers-crl blathers-crl Bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels May 21, 2026
@trunk-io

trunk-io Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

😎 Merged successfully - details.

@blathers-crl
blathers-crl Bot requested review from golgeek and srosenberg May 21, 2026 15:54
@blathers-crl

blathers-crl Bot commented May 21, 2026

Copy link
Copy Markdown
Author

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes OR fixes for serious issues. Non-production includes test-only changes, build system changes, etc. Serious issues are defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to. Reference the approved ENGREQ ticket in the PR body (e.g., "Fixes ENGREQ-123").

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl Bot added backport Label PR's that are backports to older release branches T-testeng TestEng Team labels May 21, 2026
@cockroach-teamcity

Copy link
Copy Markdown
Member

This change is Reviewable

@blathers-crl blathers-crl Bot added the backport-test-only Used to denote the backport has only non-production changes label May 21, 2026
@blathers-crl

blathers-crl Bot commented May 21, 2026

Copy link
Copy Markdown
Author

✅ PR #170745 is compliant with backport policy

Confidence: high
Backward compatible: true
Explanation: The pull request is compliant with the backport policy for CockroachDB as it involves changes to non-production code, specifically to support testing environments. The PR title and body indicate that the update is for roachprod, which is used primarily in testing and not in production environments. It upgrades the Prometheus version used in testing to address observed stability issues without changing any production behavior. Furthermore, the release justification explicitly mentions 'Test only changes', clearly aligning with the exception for test-only changes in the backport policy. Additionally, the Labels field in the PR details includes 'T-testeng', further supporting that this change is relevant to testing infrastructure.

ENGREQ Check Skipped: Test-only backport.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@kyleli03

Copy link
Copy Markdown
Contributor

/trunk merge

@trunk-io
trunk-io Bot merged commit ef25932 into release-25.4 May 21, 2026
23 checks passed
@trunk-io
trunk-io Bot deleted the blathers/backport-release-25.4-170676 branch May 21, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches backport-test-only Used to denote the backport has only non-production changes blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-testeng TestEng Team v25.4.12

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants