roachtest: allow full cluster backups in OR recovery test#170783
Closed
kev-cao wants to merge 1 commit into
Closed
roachtest: allow full cluster backups in OR recovery test#170783kev-cao wants to merge 1 commit into
kev-cao wants to merge 1 commit into
Conversation
This reverts the workaround in #170148 that limited the OR recovery test to database/table backups. The flakiness that change was working around was actually caused by revision history backups being enabled by default in OR, which #170682 addresses by skipping revision history in this test. With that fix in place, we can once again delete SSTs after the link phase via a pausepoint and exercise full cluster backups. Epic: none Release note: None Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Member
|
This change is |
Contributor
Author
|
Not to be merged until we let #170682 bake for a bit and validate that the flakiness has indeed been resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts the workaround in #170148 that limited the OR recovery test
to database/table backups. The flakiness that change was working around
was actually caused by revision history backups being enabled by default
in OR, which #170682 addresses by skipping revision history in this
test. With that fix in place, we can once again delete SSTs after the
link phase via a pausepoint and exercise full cluster backups.
Epic: none
Release note: None
Co-Authored-By: roachdev-claude roachdev-claude-bot@cockroachlabs.com