sql: use metamorphic defaults for optimizer testing knobs in logictest

[lohitkolluri]

Summary

• Use metamorphic constants for logictest defaults of optimizer-cost-perturbation and disable-opt-rule-probability flags
• Aligns with testing_optimizer_cost_perturbation and testing_optimizer_disable_rule_probability session settings used by costfuzz and unoptimized-query-oracle
• Improves optimizer test coverage during metamorphic logictest runs

Fixes #93825

Test plan

• ./dev build pkg/sql/logictest

Release note: None

[trunk-io]

Merging to master in this repository is managed by Trunk.

• To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

[blathers-crl]

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

I have added a few people who may be able to assist in reviewing:

• @rytaft (author of sql: use optimizer cost perturbation and disable rule settings for metamorphic testing #93825)
• @yuzefovich (commented on sql: use optimizer cost perturbation and disable rule settings for metamorphic testing #93825)

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

[cockroach-teamcity]

This change is 

[blathers-crl]

Thank you for updating your pull request.

Before a member of our team reviews your PR, I have some potential action items for you:

• We notice you have more than one commit in your PR. We try break logical changes into separate commits, but commits such as "fix typo" or "address review commits" should be squashed into one commit and pushed with --force
• Please ensure your git commit message contains a release note.
• When CI has completed, please ensure no errors have appeared.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

[blathers-crl]

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

[blathers-crl]

Thank you for updating your pull request.

Before a member of our team reviews your PR, I have some potential action items for you:

• We notice you have more than one commit in your PR. We try break logical changes into separate commits, but commits such as "fix typo" or "address review commits" should be squashed into one commit and pushed with --force
• When CI has completed, please ensure no errors have appeared.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

[lohitkolluri]

@rytaft @michae2 — when you have a moment, could you please take another look?

[rytaft]

@lohitkolluri thanks for the contribution! Have you tested with COCKROACH_LOGIC_TEST_OPTIMIZER_METAMORPHIC=true on any files? What happens if you set the default value to true?

It will be nice to have this option available, but unless the metamorphic constant is enabled, it doesn't really provide us any additional test coverage we didn't already have with the existing logictest flags.

[lohitkolluri]

Good point — I've flipped the default to true in 48f5d0b.

logicTestOptimizerMetamorphicEnabled = envutil.EnvOrDefaultBool(
    "COCKROACH_LOGIC_TEST_OPTIMIZER_METAMORPHIC", true)

A few things I verified:

1. The metamorphic constants only activate in metamorphic (race) builds — ConstantWithTestChoice always returns 0 in normal builds, so the env var default doesn't affect non-race CI at all.

2. Deterministic tests are already guarded — EXPLAIN tests (execbuilder) and SQLite logictests have DisableOptimizerPerturbations: true set, so they won't be perturbed regardless.

3. ForceProductionValues overrides — Configs that set this already zero out the knobs, so they're unaffected too.

I ran the non-EXPLAIN logictest files locally with the env var set and they passed, so this should be safe to merge as-is. Let me know if you'd like any other adjustments.

[rytaft]

Thanks! Assuming CI passes, this

Thanks again for the contribution!

@rytaft reviewed 21 files and all commit messages, and made 1 comment.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on michae2).

[lohitkolluri]

Thanks for the review, Rebecca! I appreciate you taking the time to look through the changes.

I'll keep an eye on CI and wait for the remaining review. Thanks again!

[lohitkolluri]

@michae2 could you please trigger the CI workflows when you get a chance? Rebecca has approved the change, and I'd appreciate a final look from you when convenient. Thanks!

[lohitkolluri]

Hi, I’ve put up a patch that should address the CI failures. When you have a chance, could you please take a look and review it? Also, if possible, could you trigger the CI once reviewed?

[blathers-crl]

Thank you for updating your pull request.

Before a member of our team reviews your PR, I have some potential action items for you:

• We notice you have more than one commit in your PR. We try break logical changes into separate commits, but commits such as "fix typo" or "address review commits" should be squashed into one commit and pushed with --force
• Please ensure your git commit message contains a release note.
• When CI has completed, please ensure no errors have appeared.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

[lohitkolluri]

@rytaft @michae2 All CI checks are passing now. Would you like me to squash the commits and push an updated branch?

[michae2]

Thanks @lohitkolluri, no need to squash. We will merge this in a little bit, we're currently making some changes to our CI process so there will be a delay of a day or two.

[lohitkolluri]

Thanks, Michael. Appreciate the update and the review. I'll leave the branch as-is and keep an eye on the PR. Thanks again for your help!