sql/parser: require parens around resource group options#170976
Draft
rafiss wants to merge 1 commit into
Draft
Conversation
The grammar for `with_resource_group_options` previously accepted both `WITH <opt> = <val>, ...` and `WITH (<opt> = <val>, ...)`. Because `BUCKET_COUNT` is in the lexer's `WITH_LA` lookahead set, supporting the unparenthesized form required four grammar alternatives (the `WITH` and `WITH_LA` variants of each), and the generated BNF surfaced this as duplicate `'WITH' ...` lines in `stmt_block.bnf`. PR cockroachdb#170894 made the `Format` methods always emit the parenthesized form, so the unparenthesized grammar paths are no longer needed for the parse/format round-trip. Drop them and require parentheses, matching CRDB convention for arbitrary KV-style option lists (`CREATE TABLE` storage params, `BACKUP ... WITH OPTIONS (...)`, etc.). Resolves: cockroachdb#170788 Release note: None
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Member
|
This change is |
Collaborator
|
Seems reasonable to me. I originally tried to make the non-parens syntax work to match the outcome brief. But I think consistency with other syntax is more reasonable. Thoughts on whether we should be using this arbitrary option list as opposed to making Weight_CPU and friends keywords? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The grammar for
with_resource_group_optionspreviously accepted bothWITH <opt> = <val>, ...andWITH (<opt> = <val>, ...).Because
BUCKET_COUNTis in the lexer'sWITH_LAlookahead set, supporting the unparenthesized form required four grammar alternatives (theWITHandWITH_LAvariants of each), and the generated BNF surfaced this as duplicate'WITH' ...lines instmt_block.bnf.PR #170894 made the
Formatmethods always emit the parenthesized form, so the unparenthesized grammar paths are no longer needed for the parse/format round-trip. Drop them and require parentheses, matching CRDB convention for arbitrary KV-style option lists (CREATE TABLEstorage params,BACKUP ... WITH OPTIONS (...), etc.).Resolves: #170788
Release note: None