build: tweak docker and kernel settings for cc integration tests#171313
Closed
chenbh wants to merge 1 commit into
Closed
build: tweak docker and kernel settings for cc integration tests#171313chenbh wants to merge 1 commit into
chenbh wants to merge 1 commit into
Conversation
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Member
|
This change is |
The current build of the runners is unable to run the cc integration tests. More specifically, all of the k3d tests are failing. This commit tweaks the docker daemon and system settings to partially fix the tests. This will need to be paired with changes in the managed-service repo to fully unblock the Ubuntu 24.04 runner migration The docker LimitNOFILE changes are return to old behaviour, where the current runners have a limit of at least 1048576 (probably infinity, but I didn't dig too deeply) The `inotify.max_user_instances` is new, the current runners have it set to the default 128. For reasons I'm not sure of, k3d is now requiring more instances and will fail to start. Note that the max is still way higher than the current value of 256 Fixes: CC-35466
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current build of the runners is unable to run the cc integration tests. More specifically, all of the k3d tests are failing. This commit tweaks the docker daemon and system settings to partially fix the tests. This will need to be paired with changes in the managed-service repo to fully unblock the Ubuntu 24.04 runner migration
The docker
LimitNOFILEchanges are returning to old behaviour, where the old runners have a limit of at least 1048576 (probably infinity, but I didn't dig too deeply)The
inotify.max_user_instancesis new, the old runners have it set to the default 128. For reasons I'm not sure of, k3d is now requiring more instances and will fail to start. Note that the max is still way higher than the proposed value of 256Informs: CC-35466