Remove known limitations page (#22325)

* remove Known Limitations page; move remaining KLs to includes

Author: taroface

src/current/_data/redirects.yml

@@ -553,6 +553,10 @@
 
 # Removed Pages
 
+- destination: ../releases/v25.4.md#known-limitations
+  sources: ['known-limitations.md']
+  versions: ['v25.4']
+
 - destination: licensing-faqs.md
   sources: ['enterprise-licensing.md']
   versions: ['v23.1', 'v23.2', 'v24.1', 'v24.2', 'v24.3']

src/current/_includes/releases/v25.4/v25.4.0.md

@@ -17,7 +17,7 @@ Before [upgrading to CockroachDB v25.4]({% link v25.4/upgrade-cockroach-version.
   - [Features that require upgrade finalization](#v25-4-0-features-that-require-upgrade-finalization)
   - [Key cluster setting changes](#v25-4-0-key-cluster-setting-changes)
   - [Deprecations] (#v25-4-0-deprecations)
-  - [Known limitations](#v25-4-0-known-limitations)
+  - [Known limitations](#known-limitations)
 
 {% include releases/new-release-downloads-docker-image.md release=include.release %}
 
@@ -270,6 +270,34 @@ Before you upgrade, review these changes and other information about the new maj
 
 {% include releases/v25.4/deprecations.md %}
 
-<h4 id="v25-4-0-known-limitations">Known limitations</h4>
+<h4 id="known-limitations">Known limitations</h4>
 
-For information about new and unresolved limitations in CockroachDB v25.4, with suggested workarounds where applicable, refer to [Known Limitations]({% link v25.4/known-limitations.md %}).
+This section describes newly identified limitations in CockroachDB v25.4.
+
+##### Views
+
+- The `security_invoker` attribute for views is not supported. Views always use the view definer's privileges when checking permissions. [#138918](https://github.com/cockroachdb/cockroach/issues/138918)
+- Casting subqueries to [user-defined types]({% link v25.4/create-type.md %}) (including `ENUM`s) in views is not supported. [#108184](https://github.com/cockroachdb/cockroach/issues/108184)
+
+##### User-defined functions
+
+- User-defined functions are not supported in partial index predicates. [#155488](https://github.com/cockroachdb/cockroach/issues/155488)
+- Views cannot reference a UDF that contains mutation statements (`INSERT`, `UPDATE`, `UPSERT`, `DELETE`). [#151686](https://github.com/cockroachdb/cockroach/issues/151686)
+
+##### Stored procedures
+
+- Pausable portals are not supported with `CALL` statements for stored procedures. [#151529](https://github.com/cockroachdb/cockroach/issues/151529)
+
+##### Mixed-isolation workloads
+
+- Mixed-isolation-level workloads must enable foreign-key check locking for `SERIALIZABLE` transactions to avoid race conditions. [#151663](https://github.com/cockroachdb/cockroach/issues/151663#issuecomment-3222083180)
+
+##### Data domiciling
+
+- When using the `infer_rbr_region_col_using_constraint` option, inserting rows with `DEFAULT` for the region column uses the database's primary region instead of inferring the region from the parent table via foreign-key constraint. [#150783](https://github.com/cockroachdb/cockroach/issues/150783)
+
+{% comment %}
+{{site.data.alerts.callout_info}}
+Limitations will be added as they are discovered.
+{{site.data.alerts.end}}
+{% endcomment %}

src/current/_includes/sidebar-all-releases.json

@@ -34,12 +34,6 @@
     "/releases/release-support-policy.html"
   ]
 },
-{
-  "title": "Known Limitations",
-  "urls": [
-    "/${VERSION}/known-limitations.html"
-  ]
-},
 {% assign advisories = site.pages | where_exp: "advisories", "advisories.path contains 'advisories'" | where_exp: "advisories", "advisories.index != 'true'" %}
 {
  "title": "Technical Advisories",

src/current/_includes/sidebar-releases.json

@@ -49,12 +49,6 @@
       "urls": [
         "/releases/release-support-policy.html"
       ]
-    },
-    {
-      "title": "Known Limitations",
-      "urls": [
-        "/${VERSION}/known-limitations.html"
-      ]
     }
   ]
 },

src/current/_includes/v25.4/known-limitations/alter-sequence-limitations.md

@@ -0,0 +1 @@
+- Altering the minimum or maximum value of a series does not check the current value of a series. This means that it is possible to silently set the maximum to a value less than, or a minimum value greater than, the current value. [#23719](https://github.com/cockroachdb/cockroach/issues/23719)

src/current/_includes/v25.4/known-limitations/alter-table-add-column-limitations.md

@@ -0,0 +1,10 @@
+- It is currently not possible to [add a column]({% link {{ page.version.version }}/alter-table.md %}#add-column) to a table when:
+    - The column uses a [sequence]({% link {{ page.version.version }}/create-sequence.md %}) as the [`DEFAULT`]({% link {{ page.version.version }}/default-value.md %}) value, for example using `nextval()`.
+    - The column uses `GENERATED ALWAYS AS IDENTITY` or `GENERATED BY DEFAULT AS IDENTITY`, unless the table being altered is empty.
+
+    This is because CockroachDB does not support back-filling sequential column data. [#42508](https://github.com/cockroachdb/cockroach/issues/42508)
+- When executing an [`ALTER TABLE ADD COLUMN`]({% link {{ page.version.version }}/alter-table.md %}#add-column) statement with a [`DEFAULT`]({% link {{ page.version.version }}/default-value.md %}) expression, new values generated:
+    - Use the default [search path]({% link {{ page.version.version }}/sql-name-resolution.md %}#search-path) regardless of the search path configured in the current session via `SET SEARCH_PATH`.
+    - Use the UTC time zone regardless of the time zone configured in the current session via [`SET TIME ZONE`]({% link {{ page.version.version }}/set-vars.md %}).
+    - Have no default database regardless of the default database configured in the current session via [`SET DATABASE`]({% link {{ page.version.version }}/set-vars.md %}), so you must specify the database of any tables they reference.
+    - Use the transaction timestamp for the `statement_timestamp()` function regardless of the time at which the `ALTER` statement was issued.

src/current/_includes/v25.4/known-limitations/client-connections-limitations.md

@@ -0,0 +1 @@
+- When a node has both a high number of client connections and running queries, the node may crash due to memory exhaustion. This is due to CockroachDB not accurately limiting the number of clients and queries based on the amount of available RAM on the node. To prevent memory exhaustion, monitor each node's memory usage and ensure there is some margin between maximum CockroachDB memory usage and available system RAM. For more details about memory usage in CockroachDB, see [this blog post](https://www.cockroachlabs.com/blog/memory-usage-cockroachdb/).

src/current/_includes/v25.4/known-limitations/collate-limitations.md

@@ -0,0 +1 @@
+- Many string operations are not properly overloaded for [collated strings]({% link {{ page.version.version }}/collate.md %}). For example, the `||` concatenation operator works with regular strings but returns an error with collated strings. [#10679](https://github.com/cockroachdb/cockroach/issues/10679)

src/current/_includes/v25.4/known-limitations/column-family-limitations.md

@@ -0,0 +1 @@
+- When creating or updating a row, if the combined size of all values in a single [column family]({% link {{ page.version.version }}/column-families.md %}) exceeds the [max range size]({% link {{ page.version.version }}/configure-replication-zones.md %}#range-max-bytes) for the table, the operation may fail, or cluster performance may suffer. As a workaround, you can either [manually split a table's columns into multiple column families]({% link {{ page.version.version }}/column-families.md %}#manual-override), or you can [create a table-specific zone configuration]({% link {{ page.version.version }}/configure-replication-zones.md %}#create-a-replication-zone-for-a-table) with an increased max range size.

src/current/_includes/v25.4/known-limitations/comment-on-limitations.md

@@ -0,0 +1 @@
+- The [`COMMENT ON`]({% link {{ page.version.version }}/comment-on.md %}) statement associates comments to databases, tables, or columns. However, the internal table (`system.comments`) in which these comments are stored is not captured by a [`BACKUP`]({% link {{ page.version.version }}/backup.md %}) of an individual table or database. As a workaround, take a cluster backup instead, as the `system.comments` table is included in cluster backups. [#44396](https://github.com/cockroachdb/cockroach/issues/44396)