Fix cross-version links in v23.1 documentation#22275
Open
ebembi-crdb wants to merge 3 commits into
Open
Conversation
Replace hardcoded v24.1 image references with dynamic version variable.
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
added 2 commits
January 27, 2026 16:30
Replace broken Liquid syntax with working path format:
- From: {{ 'images/vX.X/...' | relative_url }}
- To: /docs/images/{{ page.version.version }}/...
Change nested {{ page.version.version }} to hardcoded v23.1 in image paths.
Liquid cannot evaluate nested {{ }} inside strings.
Contributor
|
@ebembi-crdb this version of CRDB is no longer supported per https://www.cockroachlabs.com/docs/releases/release-support-policy.html#supported-versions is it possible for us to not bother updating links for this version? or is it necessary anyway in order to archive these versions, etc? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{{ page.version.version }}Changes
Test Plan