Vendor SQL diagrams as local includes#23404
Merged
rmloveland merged 4 commits intoMay 29, 2026
Merged
Conversation
Fixes DOC-17061 Summary of changes: - Vendored generated SQL diagram HTML into local include files. - Replaced SQL diagram remote includes with local versioned includes. - Added scripts to vendor and verify SQL diagram includes.
✅ Deploy Preview for cockroachdb-api-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Files changed:
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
Contributor
Author
|
NB this relates to #23297 |
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
3 tasks
Contributor
Review: PR #23404 — Vendor SQL diagrams as local includesOverviewThis PR adds vendored SQL diagram HTML files under Key findingsStrengths:
Questions / Suggestions (non-blocking):
LGTM overall — the approach is solid and consistent with the other vendoring PRs. @rmloveland |
Contributor
Author
|
@ebembi-crdb thanks for the review. Replying to your numbered points:
|
The supported sync and validation process should be owned by follow-up EDUENG work.
Contributor
Author
|
Updated the PR:
Follow-up issue: https://cockroachlabs.atlassian.net/browse/EDUENG-764 |
…remote_include-sql-diagrams
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes DOC-17061
Summary of changes:
Vendored generated SQL diagram HTML into local include files.
Replaced SQL diagram remote includes with local versioned includes.
Added scripts to vendor and verify SQL diagram includes.